After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615133 - Move GtkBuilder and .desktop files to data directory.
Move GtkBuilder and .desktop files to data directory.
Status: RESOLVED FIXED
Product: gnome-nettool
Classification: Applications
Component: general
2.30.x
Other All
: Normal minor
: ---
Assigned To: Germán Poo-Caamaño
Rodrigo Moya
Depends on:
Blocks:
 
 
Reported: 2010-04-08 03:14 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-07-11 21:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move GtkBuilder and .desktop files to data directory. (291.19 KB, patch)
2010-04-08 03:17 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Move GtkBuilder and .desktop files to data directory.v2 (291.71 KB, patch)
2010-04-08 04:35 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-04-08 03:14:29 UTC 
Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-08 03:17:03 UTC 
Created attachment 158162 [details] [review]
Move GtkBuilder and .desktop files to data directory.
Comment 2 Javier Jardón (IRC: jjardon) 2010-04-08 04:35:55 UTC 
Created attachment 158171 [details] [review]
Move GtkBuilder and .desktop files to data directory.v2

Here the correct patch
Comment 3 Germán Poo-Caamaño 2010-04-08 05:24:58 UTC 
Review of attachment 158171 [details] [review]:

It looks good.  It good be nice if you add the rationale of the change in the commit message.
Comment 4 Javier Jardón (IRC: jjardon) 2010-04-08 05:47:35 UTC 
Comment on attachment 158171 [details] [review]
Move GtkBuilder and .desktop files to data directory.v2

commit a8008f5b5987159319eeede2f0f5ecc9f3aad12d
Comment 5 Javier Jardón (IRC: jjardon) 2010-04-08 05:48:08 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thank you for the review!
Comment 6 Frederic Peters 2010-07-11 21:24:13 UTC 
commit 7b9a5bde74662a1476c368aaa3492df3e1bf5a5d
Author: Frédéric Péters <fpeters@0d.be>
Date:   Sun Jul 11 22:54:07 2010 +0200

    Fixed installation directory of GtkBuilder UI file
    
    This syncs the .ui installation directory given in data/Makefile.am and the
    directory used by the actual program to find the file at runtime. This had
    been broken by a8008f5.


(and as my reason for looking at gnome-nettool tonight was checking if a GTK+ 3 release could be made tomorrow I also ended up updating the minimym gtk+ version in configure.ac).