After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614848 - don't use " - File Browser" in the window title
don't use " - File Browser" in the window title
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-05 01:59 UTC by Hylke Bons
Modified: 2010-06-08 09:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Removes the "File Browser" title in the window - only showing the name of the current folder (1019 bytes, patch)
2010-06-07 20:31 UTC, Marcus Carlson
accepted-commit_now Details | Review

Description Hylke Bons 2010-04-05 01:59:17 UTC
The HIG highly recommends not using the application name in the window title.
gnome-shell picks up the application name from the .desktop file and shows it
the window menu in the top bar so it would be a duplication.
Comment 1 Marcus Carlson 2010-06-07 20:31:31 UTC
Created attachment 162970 [details] [review]
Removes the "File Browser" title in the window - only showing the name of the current folder
Comment 2 Cosimo Cecchi 2010-06-07 23:14:29 UTC
Review of attachment 162970 [details] [review]:

Looks good, please commit to master.
Comment 3 Luca Ferretti 2010-06-07 23:40:35 UTC
Hmmm... If my memories doesn't fail, the " - File Manager" suffix was added to differentiate[1] spatial windows ("$FOLDER") from explore windows ("$FOLDER - File Manager").

This when spatial view was our default, and was logical to think of nautilus windows as document windows (1 folder <-> 1 window).
But now? Whit this change you can open N different windows showing the same content, all of them using the same window title. 

IMHO we should keep the current " - File Manager" suffix at least when you are using the spatial interface as default (i.e. when /apps/nautilus/preferences/always_use_browser is FALSE) but we could also need a good way to differentiate 2 or more browser windows showing the same location[2]


[1] or, maybe, was the "$FOLDER - " prefix to be added to differentiate 2 or more "File Browser" windows, we should check ChangeLogs
[2] or two locations with same name, but different paths ;)
Comment 4 Cosimo Cecchi 2010-06-07 23:48:29 UTC
(In reply to comment #3)

> But now? Whit this change you can open N different windows showing the same
> content, all of them using the same window title. 

What would change from the current behaviour? You can open N different windows with the same content and same window title also now.
 
> IMHO we should keep the current " - File Manager" suffix at least when you are
> using the spatial interface as default (i.e. when
> /apps/nautilus/preferences/always_use_browser is FALSE) but we could also need
> a good way to differentiate 2 or more browser windows showing the same
> location[2]

The first proposal is a good idea, the second one is a completely separate bug, because you have exactly the same problem without this patch.
Comment 5 Cosimo Cecchi 2010-06-08 09:52:38 UTC
I pushed Marcus' patch to master, with the addition suggested by Luca.

Closing as FIXED.
Comment 6 Hylke Bons 2010-06-08 09:54:10 UTC
yay, thanks!g