After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614803 - v4l2: add tv-norm property
v4l2: add tv-norm property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-04 13:00 UTC by Rob Clark
Modified: 2011-06-15 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add norm property (12.17 KB, patch)
2010-04-04 13:01 UTC, Rob Clark
none Details | Review
v4l2: add norm property (12.20 KB, patch)
2010-04-26 21:56 UTC, Rob Clark
committed Details | Review

Description Rob Clark 2010-04-04 13:00:23 UTC
based on a patch by Guennadi Liakhovetski.

this patch should apply cleanly on top of the patches in #612244 (or with some minor tweaks on top of latest git)
Comment 1 Rob Clark 2010-04-04 13:01:13 UTC
Created attachment 157875 [details] [review]
add norm property
Comment 2 Rob Clark 2010-04-15 06:05:38 UTC
Review of attachment 157875 [details] [review]:

::: sys/v4l2/gstv4l2object.c
@@ +348,3 @@
+      {V4L2_STD_SECAM_K1, "SECAM-K1", "SECAM-K1"},
+      {V4L2_STD_SECAM_L, "SECAM-L", "SECAM-L"},
+      {V4L2_STD_SECAM_LC, "SECAM-Lc", "SECAM-Lc"},

opps, need a:

      {0, NULL, NULL}

I'll re-submit patch in a few days when I get a chance.. please don't merge the current patch yet.
Comment 3 Rob Clark 2010-04-26 21:56:02 UTC
Created attachment 159648 [details] [review]
v4l2: add norm property
Comment 4 Sebastian Dröge (slomo) 2011-05-24 08:47:59 UTC
commit 9c9585116cf49d2a2a1e13c12a17e2a09a729526
Author: Rob Clark <rob@ti.com>
Date:   Sun Apr 4 06:43:41 2010 -0500

    v4l2: add norm property
    
    Based on a patch by Guennadi Liakhovetski.
    
    v2: updates because I forgot to add GstTuner interface to v4l2sink
    v3: update to add all possible values to norm enum