After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614515 - Func to substitute GTK_WIDGET_SET_FLAGS (widget, GTK_HAS_DEFAULT)?
Func to substitute GTK_WIDGET_SET_FLAGS (widget, GTK_HAS_DEFAULT)?
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.20.x
Other All
: Normal blocker
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 69872
 
 
Reported: 2010-03-31 21:36 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-04-26 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Introduce _gtk_widget_set_has_default() internal function (3.66 KB, patch)
2010-04-14 12:35 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-03-31 21:36:48 UTC 
This function should be substituted in GTK+ internal code

kalikiana comment:
Hm... this one is ugly because gtk_widget_grab_default is not enough to set the
flag and there's an awkward interdepedency on GtkWindow. I guess we need an
internal function here as well unless somebody can think of something more
elegant.
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-14 12:35:40 UTC 
Created attachment 158710 [details] [review]
Introduce _gtk_widget_set_has_default() internal function
Comment 2 Emmanuele Bassi (:ebassi) 2010-04-26 18:09:12 UTC 
Review of attachment 158710 [details] [review]:

looks good to me
Comment 3 Javier Jardón (IRC: jjardon) 2010-04-26 19:18:23 UTC 
Comment on attachment 158710 [details] [review]
Introduce _gtk_widget_set_has_default() internal function

commit 41a073263a5b16c2ecde58d7ef0f6ad2d296b3ac
Comment 4 Javier Jardón (IRC: jjardon) 2010-04-26 19:19:05 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thanks for the review.