After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614510 - Needed func for GTK_WIDGET_SET_FLAGS (widget, TOPLEVEL) ?
Needed func for GTK_WIDGET_SET_FLAGS (widget, TOPLEVEL) ?
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.20.x
Other All
: Normal blocker
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 69872 594957
 
 
Reported: 2010-03-31 21:15 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-04-26 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Introduce _gtk_widget_set_is_toplevel() internal function (1.78 KB, patch)
2010-04-12 16:21 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Replace GTK_WIDGET_SET_FLAGS (widget, TOPLEVEL) by the new function (2.36 KB, patch)
2010-04-12 16:22 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Introduce _gtk_widget_set_is_toplevel() internal function.v2 (3.58 KB, patch)
2010-04-14 12:48 UTC, Javier Jardón (IRC: jjardon) 		needs-work Details | Review

Description Javier Jardón (IRC: jjardon) 2010-03-31 21:15:51 UTC 
This function should be substituted in GTK+ internal code
Should be a public api for this?

See https://bugzilla.gnome.org/show_bug.cgi?id=69872#c99 for a former discussion.
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-12 16:21:38 UTC 
Created attachment 158498 [details] [review]
Introduce _gtk_widget_set_is_toplevel() internal function
Comment 2 Javier Jardón (IRC: jjardon) 2010-04-12 16:22:31 UTC 
Created attachment 158499 [details] [review]
Replace GTK_WIDGET_SET_FLAGS (widget, TOPLEVEL) by the new function
Comment 3 Christian Dywan 2010-04-13 14:26:23 UTC 
Looks good to me. I guess you could do this in one commit since it doesn't really make sense on its own.
Comment 4 Christian Dywan 2010-04-13 14:27:43 UTC 
Bugzilla spits obscure errors at me when I try to set the review state. Regard this as 'reviewed' anyway.
Comment 5 Javier Jardón (IRC: jjardon) 2010-04-14 12:48:46 UTC 
Created attachment 158714 [details] [review]
Introduce _gtk_widget_set_is_toplevel() internal function.v2

Updated patch
Comment 6 Emmanuele Bassi (:ebassi) 2010-04-26 18:06:11 UTC 
Review of attachment 158714 [details] [review]:

::: gtk/gtkwindow.c
@@ +8405,3 @@
     {
   else
+      _gtk_widget_set_is_toplevel (GTK_WIDGET (window), TRUE);

this should be:

  _gtk_widget_set_is_toplevel (GTK_WIDGET (window), FALSE);

also, since we're casting twenty bazillion times in the same function, can we cast just once to GtkWidget and be done with it?
Comment 7 Emmanuele Bassi (:ebassi) 2010-04-26 18:06:12 UTC 
Review of attachment 158714 [details] [review]:

::: gtk/gtkwindow.c
@@ +8405,3 @@
     {
   else
+      _gtk_widget_set_is_toplevel (GTK_WIDGET (window), TRUE);

this should be:

  _gtk_widget_set_is_toplevel (GTK_WIDGET (window), FALSE);

also, since we're casting twenty bazillion times in the same function, can we cast just once to GtkWidget and be done with it?
Comment 8 Javier Jardón (IRC: jjardon) 2010-04-26 19:19:32 UTC 
Comment on attachment 158714 [details] [review]
Introduce _gtk_widget_set_is_toplevel() internal function.v2

committed with your comments

commit 45257e31c721d1ffbd2cdcfb25ae637d7e1e7b29
Comment 9 Javier Jardón (IRC: jjardon) 2010-04-26 19:20:17 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thanks for the reviews.