GNOME Bugzilla – Bug 614471
[qtdemux] Gstreamer not reading replaygain tags from m4a files
Last modified: 2010-04-02 18:42:50 UTC
Not sure if this is a problem with gstreamer/qtdemux or aacgain, but if I use aacgain (http://altosdesign.com/aacgain/martelli/) to add replaygain tags to m4a files, Rhythmbox does not see them (or at least the replaygain plugin doesn't). I tested a file with "gst-launch file://file.m4a | decodebin ! fakesink -t" and I can see all the usual tags, but not the replaygain ones. If I do the same on an MP3 file, the replaygain tags are read correctly. This suggests a possible problem with gstreamer rather than Rhythmbox. I don't know any other simple way to list the tags of an m4a file in Linux, but if I view the extended tags with e.g. MP3Tag in Windows, I can see the replaygain tags are there. OS is Fedora i386. Relevant packages are: gstreamer-plugins-base-devel-0.10.28-1.fc12.i686 gstreamer-plugins-ugly-0.10.13-1.fc12.i686 gstreamer-0.10.28-2.fc12.i686 gstreamer-tools-0.10.28-2.fc12.i686 gstreamer-python-0.10.16-1.fc12.i686 gstreamer-ffmpeg-0.10.9-1.fc12.i686 gstreamer-plugins-bad-free-0.10.18-1.fc12.i686 gstreamer-devel-0.10.28-2.fc12.i686 gstreamer-plugins-good-0.10.21-1.fc12.i686 gstreamer-plugins-bad-0.10.17-4.fc12.i686 gstreamer-python-devel-0.10.16-1.fc12.i686 gstreamer-plugins-bad-free-devel-0.10.18-1.fc12.i686 gstreamer-plugins-base-0.10.28-1.fc12.i686 rhythmbox-0.12.8.20100328git-1.f12.i686 aacgain-1.8-1.i386
Seems there is this weird '----' tag atom that has some underlying info. Found some reference here: http://atomicparsley.sourceforge.net/mpeg-4files.html
Created attachment 157692 [details] [review] qtdemux: Read replaygain peak/gain tags This patch makes qtdemux read replaygain's peak and gain for tracks and albums, there are still min/max and 'undo' tags that we don't have in gstreamer tags. Are those important to you? We could add those tags if so. I've tested with gst-launch and I see the tags on the output. Can you test the patch and check if works for you? Thanks.
Just tested this patch on Fedora 12, using Rhythmbox 0.12.8 and it works perfectly now. :) Not sure what other gstreamer media players there are out there that support replaygain, but if someone knows of one, perhaps they could test this also? Excellent work, thank you.
Module: gst-plugins-good Branch: master Commit: f966ff66f867b21edcab7708aa6c155e670f68ee URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=f966ff66f867b21edcab7708aa6c155e670f68ee Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk> Date: Thu Apr 1 10:19:00 2010 -0300 qtdemux: Read replaygain peak/gain tags Make qtdemux read tags replaygain tags that are within '----' atoms. Fixes #614471