After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614412 - Grid of buttons leads to dark spot optical illusion
Grid of buttons leads to dark spot optical illusion
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
: 683731 710918 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-03-30 22:57 UTC by Robert Ancell
Modified: 2014-12-23 04:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds padding to the buttons (60.09 KB, patch)
2014-06-14 18:57 UTC, elita astrid angelina lobo 		needs-work Details | Review
adds padding to the button (60.23 KB, patch)
2014-06-16 19:36 UTC, elita astrid angelina lobo 		needs-work Details | Review
adds padding to the button (59.94 KB, patch)
2014-06-26 09:55 UTC, elita astrid angelina lobo 		none Details | Review

Description Robert Ancell 2010-03-30 22:57:56 UTC 
Using a rigid grid of buttons makes a distracting optical illusion that there are dark spots on the corners of the buttons.

Wikipedia artical:
http://en.wikipedia.org/wiki/Grid_illusion
Comment 1 elita astrid angelina lobo 2014-06-14 18:57:32 UTC 
Created attachment 278455 [details] [review]
adds padding to the buttons
Comment 2 PioneerAxon 2014-06-15 21:33:30 UTC 
Review of attachment 278455 [details] [review]:

5 is a bit too much of padding.
IMO, 2 is a better value, but 3 is fine. Any value greater than 3 makes it look really weird.

There are a few unwanted whitespace changes, please fix them.

::: data/buttons-financial.ui
@@ +2373,3 @@
         <property name="right_attach">9</property>
         <property name="x_options">GTK_EXPAND | GTK_SHRINK | GTK_FILL</property>
+        <property name="y_options">GTK_EXPAND | GTK_SHRINK | GTK_FILL</property> 

Unwanted whitespace change.

::: data/buttons-programming.ui
@@ +2391,3 @@
             <property name="y_options">GTK_EXPAND | GTK_SHRINK | GTK_FILL</property>
+             <property name="x_padding">5</property>
+            <property name="y_padding">5</property> 

Tab instead of 8 whitespace, trailing whitespace.
Comment 3 elita astrid angelina lobo 2014-06-16 19:36:08 UTC 
Created attachment 278554 [details] [review]
adds padding to the button
Comment 4 PioneerAxon 2014-06-17 18:50:23 UTC 
Review of attachment 278554 [details] [review]:

I am a bit pessimistic about using 3 pixels as button padding. My personal opinion is 2 pixels.

Waiting for other's comment on how many pixels would be better as padding.

Plus following issues.

::: data/buttons-financial.ui
@@ +2354,3 @@
         <property name="right_attach">8</property>
         <property name="x_options">GTK_EXPAND | GTK_SHRINK | GTK_FILL</property>
+        <property name="y_options">GTK_EXPAND | GTK_SHRINK | GTK_FILL</property> 

Whitespace change.

@@ +2373,3 @@
         <property name="right_attach">9</property>
         <property name="x_options">GTK_EXPAND | GTK_SHRINK | GTK_FILL</property>
+        <property name="y_options">GTK_EXPAND | GTK_SHRINK | GTK_FILL</property> 

Whitespace change.

::: data/buttons-programming.ui
@@ +2391,3 @@
             <property name="y_options">GTK_EXPAND | GTK_SHRINK | GTK_FILL</property>
+            <property name="x_padding">3</property>
+            <property name="y_padding">3</property> 

Trailing whitespace,
Comment 5 elita astrid angelina lobo 2014-06-26 09:55:11 UTC 
Created attachment 279302 [details] [review]
adds padding to the button
Comment 6 Michael Catanzaro 2014-12-23 04:17:44 UTC 
*** Bug 683731 has been marked as a duplicate of this bug. ***
Comment 7 Michael Catanzaro 2014-12-23 04:17:50 UTC 
*** Bug 710918 has been marked as a duplicate of this bug. ***