After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613665 - the "view previous conversations" menu item cannot be assigned a keyboard shortcut
the "view previous conversations" menu item cannot be assigned a keyboard sho...
Status: RESOLVED DUPLICATE of bug 576075
Product: empathy
Classification: Core
Component: Chat
2.28.x
Other Linux
: Normal minor
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-23 07:33 UTC by Martin Vysny
Modified: 2012-01-26 04:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.39 KB, patch)
2010-04-03 00:31 UTC, Aaron Brown
needs-work Details | Review

Description Martin Vysny 2010-03-23 07:33:44 UTC
With Pidgin I was used to open the conversation history with CTRL+L. This shortcut is assigned to the "Clear" action in Empathy. I tried to reassign the shortcut: I was able to remove the shortcut from the Clear menu item, but I cannot set any shortcut to the Contact > View Previous Conversations. The GNOME "Editable menu shortcut keys" option is enabled. I'm on fully updated Ubuntu 9.10, empathy is 2.28.1.1-0ubuntu1. Thanks!

Link to the original bug report: https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/544299
Comment 1 Aaron Brown 2010-03-24 00:00:00 UTC
From the main window, View>Previous Conversations has F3 assigned as a shortcut key, were you trying to reassign this value or from the chat window Contact>View Previous Conversations?
Comment 2 Aaron Brown 2010-03-24 00:10:02 UTC
Okay just reread the OP, ignore my previous comment.  Too early in the morning...

Pending thoughts from empathy developers et al, I'd be happy to look into this?
Comment 3 Guillaume Desmottes 2010-03-24 08:52:47 UTC
I'd say F3 should open the logger from the chat window as well.
Comment 4 Aaron Brown 2010-04-03 00:31:56 UTC
Created attachment 157778 [details] [review]
Proposed patch

Here's what I've been sitting on, I don't understand gtk enough to know how to implement the accelerator properly through code (accel_group us always NULL???)

Any advice/help will be appreciated.
Comment 5 Danielle Madeley 2012-01-26 02:54:33 UTC
Review of attachment 157778 [details] [review]:

Creating one accel_group per menuitem is wrong. We could potentially create an accel_group for the entire menu. Or port the whole thing to GtkUIManager and then merge it (could prove difficult with the updating and such, not sure).

N.B. There is no longer an empathy-contact-menu, only empathy-individual-menu.
Comment 6 Danielle Madeley 2012-01-26 04:42:45 UTC

*** This bug has been marked as a duplicate of bug 576075 ***