After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613198 - ximagesink memory leak
ximagesink memory leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-17 21:56 UTC by reuben.dowle
Modified: 2010-03-17 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the memory leak (446 bytes, patch)
2010-03-17 21:58 UTC, reuben.dowle 		committed Details | Review

Description reuben.dowle 2010-03-17 21:56:49 UTC 
Our product was leaking 5.5Mb/hour during video playback.

In gst_ximagesink_buffer_alloc if the requested geometry does not match the required geometry, a GstCaps object is copied. If the new geometry is rejected, then the copy of the GstCaps object is not unrefed.

The attached patch fixes this bug.
Comment 1 reuben.dowle 2010-03-17 21:58:31 UTC 
Created attachment 156403 [details] [review]
Patch to fix the memory leak
Comment 2 Thiago Sousa Santos 2010-03-17 22:46:52 UTC 
Pushed, thanks for the fix.


Module: gst-plugins-base
Branch: master
Commit: 621705f475bc93695e5a2105eb4aee5296bfe015
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=621705f475bc93695e5a2105eb4aee5296bfe015

Author: Reuben Dowle <reube.dowle@navico.com>
Date:   Wed Mar 17 19:24:27 2010 -0300

ximagesink: Fix caps leak

Unref caps when peer doesn't accept caps

Fixes #613198