After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613106 - support build with mozilla-js that compiled with --disable-threadsafe --enable-debug
support build with mozilla-js that compiled with --disable-threadsafe --enabl...
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-17 04:12 UTC by Maxim Ermilov
Modified: 2010-03-17 17:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
support build with mozilla-js that compiled with --disable-threadsafe --enable-debug (8.11 KB, patch)
2010-03-17 04:12 UTC, Maxim Ermilov 		committed Details | Review

Description Maxim Ermilov 2010-03-17 04:12:00 UTC 
Created attachment 156324 [details] [review]
support build with mozilla-js that compiled with --disable-threadsafe --enable-debug

support build with mozilla-js that compiled with --disable-threadsafe --enable-debug
Comment 1 Johan (not receiving bugmail) Dahlin 2010-03-17 12:14:39 UTC 
Review of attachment 156324 [details] [review]:

This looks pretty straight-forward to me. There's a probably a bit more to be done to make Gjs completely threadsafe, but I guess it can be done in follow-up patches.
https://developer.mozilla.org/en/JS_THREADSAFE and https://developer.mozilla.org/En/SpiderMonkey/Internals/Thread_Safety contains instructions on how to make gjs threadsafe.
Comment 2 Havoc Pennington 2010-03-17 14:10:39 UTC 
The patch looks fine just to make it build but I'd say there's a lot more than a bit more to actually be threadsafe ;-) more like "good luck!"