After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612918 - Support disabling X11 extensions
Support disabling X11 extensions
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.90.x
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-03-15 06:48 UTC by Emilio Pozuelo Monfort
Modified: 2011-01-07 01:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support disabling X11 extensions (2.17 KB, patch)
2010-03-15 06:49 UTC, Emilio Pozuelo Monfort 		none Details | Review
Support disabling X11 extensions (3.03 KB, patch)
2011-01-04 21:06 UTC, Emilio Pozuelo Monfort 		none Details | Review
Support disabling X11 extensions (4.30 KB, patch)
2011-01-05 01:23 UTC, Emilio Pozuelo Monfort 		none Details | Review

Description Emilio Pozuelo Monfort 2010-03-15 06:48:40 UTC 
Hi,

The attached patch from Cyril Brulebois <kibi@debian.org> makes it possible to disable X11 extensions support even when they are installed. We want this in Debian as we build GTK+ with extensions enabled for the normal build, but disable them for the special build that will be used in the graphical installer (so the extensions are installed and it was not posible to disable it).
Comment 1 Emilio Pozuelo Monfort 2010-03-15 06:49:27 UTC 
Created attachment 156161 [details] [review]
Support disabling X11 extensions
Comment 2 Matthias Clasen 2010-03-16 16:55:36 UTC 
Why do you need that ? 

If there are bugs in gdk with dealing with the absence of extensions in the server, we need to fix those.
Comment 3 Emilio Pozuelo Monfort 2010-03-16 18:49:44 UTC 
It's not because there are bugs, but because the graphical installer needs to be as small as possible, so we disable everything that is not strictly necessary (in gtk+ and everywhere)
Comment 4 Emilio Pozuelo Monfort 2010-03-16 18:50:35 UTC 
(and this means we don't need to ship many X libs)
Comment 5 Emilio Pozuelo Monfort 2010-06-15 09:26:00 UTC 
It'd be great if this could be applied, at least to GTK+3.
Comment 6 Emilio Pozuelo Monfort 2011-01-04 21:06:48 UTC 
Created attachment 177521 [details] [review]
Support disabling X11 extensions

Here's an updated patch for git master.

We already support this for other extensions. And these ones aren't mandatory, i.e. it's already possible to build gtk+ without them, so I see no harm in applying this.

Can I push this to master?
Comment 7 Matthias Clasen 2011-01-04 23:42:34 UTC 
Somewhat reluctantly. I hate to have more options to look after... 

Can we arrange things so that the default is "maybe" and we fail the build if there is an explicit --enable, but the extension is missing ? With that, I'll
accept it for gtk3
Comment 8 Emilio Pozuelo Monfort 2011-01-05 01:23:56 UTC 
Created attachment 177536 [details] [review]
Support disabling X11 extensions

Makes sense to me. Updated to do that.

Removing e.g. xfixes.pc and doing a ./configure --enable-xfixes results in:

configure: error: XFixes support requested but xfixes not found
Comment 9 Matthias Clasen 2011-01-06 19:33:24 UTC 
Ok, looks good to me now. But I've done some configure.ac revamp recently, so you'll have to rebase the patch before committing it. Note that we now maintain a list of extensions in the X_EXTENSIONS (for summary display purposes)
Comment 10 Emilio Pozuelo Monfort 2011-01-07 01:35:36 UTC 
Thanks. I've updated it to apply again and pushed to master as ec15c405cf6354e9267e7e6b7ce878c519bffe4c