After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612783 - Warning when compiling gstsubparse.c with MSVC
Warning when compiling gstsubparse.c with MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.28
Other Windows
: Normal normal
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-13 10:37 UTC by David Hoyt
Modified: 2010-03-15 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstsubparse.c patch (547 bytes, patch)
2010-03-13 10:37 UTC, David Hoyt 		rejected Details | Review

Description David Hoyt 2010-03-13 10:37:40 UTC 
Created attachment 156054 [details] [review]
gstsubparse.c patch

MSVC flags the regular expression on line 1259 of gstsubparse.c. I'm not familiar with the intent of the given reg. exp. (it appears to be 3 numbers separated by colons), but I assumed the slash wasn't needed and provided a patch for it. This eliminated the warning.
Comment 1 Sebastian Dröge (slomo) 2010-03-15 13:10:02 UTC 
Comment on attachment 156054 [details] [review]
gstsubparse.c patch

Actually it's the other way around: The outer [ and ] must be escaped properly, i.e. with a double-\

Thanks for reporting :)
Comment 2 Sebastian Dröge (slomo) 2010-03-15 13:11:14 UTC 
commit a6ffa3fbb5ce4f73c0e2b82e64cd85a4504e887b
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon Mar 15 14:10:09 2010 +0100

    subparse: Correctly escape brackets in DKS regex
    
    Fixes bug #612783.
Comment 3 David Hoyt 2010-03-15 16:15:41 UTC 
Thank you for taking the time to look at this. (c: