GNOME Bugzilla – Bug 612783
Warning when compiling gstsubparse.c with MSVC
Last modified: 2010-03-15 16:15:41 UTC
Created attachment 156054 [details] [review] gstsubparse.c patch MSVC flags the regular expression on line 1259 of gstsubparse.c. I'm not familiar with the intent of the given reg. exp. (it appears to be 3 numbers separated by colons), but I assumed the slash wasn't needed and provided a patch for it. This eliminated the warning.
Comment on attachment 156054 [details] [review] gstsubparse.c patch Actually it's the other way around: The outer [ and ] must be escaped properly, i.e. with a double-\ Thanks for reporting :)
commit a6ffa3fbb5ce4f73c0e2b82e64cd85a4504e887b Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Mon Mar 15 14:10:09 2010 +0100 subparse: Correctly escape brackets in DKS regex Fixes bug #612783.
Thank you for taking the time to look at this. (c: