After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612749 - Fix include of libtracker-client/tracker-client.h in libtracker-miner/tracker-miner.h
Fix include of libtracker-client/tracker-client.h in libtracker-miner/tracker...
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
Jamie McCracken
Depends on:
Blocks:
 
 
Reported: 2010-03-12 22:37 UTC by Michele Tameni
Modified: 2010-03-19 09:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix include of libtracker-client/tracker-client.h in libtracker-miner/tracker-miner.h (695 bytes, patch)
2010-03-12 22:37 UTC, Michele Tameni 		committed Details | Review

Description Michele Tameni 2010-03-12 22:37:17 UTC 
Created attachment 156023 [details] [review]
Fix include of libtracker-client/tracker-client.h in libtracker-miner/tracker-miner.h

Include <libtracker-miner/tracker-miner.h> in a miner out of tracker source tree 'couse compilation fail with:

/usr/include/tracker-0.7/libtracker-client/tracker.h:25:2: error: #error "only <libtracker-client/tracker-client.h> must be included directly."

This is because libtracker-miner/tracker-miner.h include libtracker-client/tracker.h and not libtracker-client/tracker-client.h

Patch attached
Comment 1 Martyn Russell 2010-03-15 10:15:48 UTC 
Comment on attachment 156023 [details] [review]
Fix include of libtracker-client/tracker-client.h in libtracker-miner/tracker-miner.h

Thanks for the patch, committed now in master!
Comment 2 Hussam Al-Tayeb 2010-03-18 23:17:52 UTC 
brasero fails to compile with tracker 0.7.25 and also with 0.7.26 
In file included from brasero-search-tracker.c:22:
/usr/include/tracker-0.7/libtracker-client/tracker.h:25:2: error: #error "only <libtracker-client/tracker-client.h> must be included directly."
Comment 3 Martyn Russell 2010-03-19 09:28:28 UTC 
(In reply to comment #2)
> brasero fails to compile with tracker 0.7.25 and also with 0.7.26 
> In file included from brasero-search-tracker.c:22:
> /usr/include/tracker-0.7/libtracker-client/tracker.h:25:2: error: #error "only
> <libtracker-client/tracker-client.h> must be included directly."

Is this the same bug? What file are you trying to include?

We have changed the policy for including in our libraries to avoid this sort of issue in the future. Only one file is included now, tracker-client.h (for libtracker-client). If you're not doing that, you need to fix your build.

Sorry for the inconvenience.