After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612575 - Improve docs of gtk_notebook_set_tab_label_packing
Improve docs of gtk_notebook_set_tab_label_packing
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-03-11 14:47 UTC by Christian Dywan
Modified: 2010-03-12 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
s/bookmark/tab label/ and point out deprecation of packing type (1.50 KB, patch)
2010-03-11 14:53 UTC, Christian Dywan 		accepted-commit_now Details | Review

Description Christian Dywan 2010-03-11 14:47:50 UTC 
I just realized, the documentation of gtk_notebook_set_tab_label_packing could be improved a little.

The use of the term "bookmark" here is misleading and not used anywhere else in GtkNotebook:

"* @expand: whether to expand the bookmark or not"

I propose this should say s/bookmark/tab label/.

Also the "Deprecated:" tag should explicitly point out that @pack_type should not be used anymore, otherwise it seems as if the mentioned child properties alone would replace it.
Comment 1 Christian Dywan 2010-03-11 14:53:05 UTC 
Created attachment 155864 [details] [review]
s/bookmark/tab label/ and point out deprecation of packing type
Comment 2 Matthias Clasen 2010-03-12 14:29:26 UTC 
Comment on attachment 155864 [details] [review]
s/bookmark/tab label/ and point out deprecation of packing type

Looks good, please commit
Comment 3 Christian Dywan 2010-03-12 16:56:50 UTC 
Pushed to master.