GNOME Bugzilla – Bug 612497
Does not compile with -DGSEAL_ENABLED
Last modified: 2010-06-22 16:28:07 UTC
This module does not build with -DGSEAL_ENABLED. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. gdl-dock-object.c: In function ‘gdl_dock_object_real_detach’: gdl-dock-object.c:363: error: ‘GtkWidget’ has no member named ‘parent’ gdl-dock-object.c:364: error: ‘GtkWidget’ has no member named ‘parent’ gdl-dock-object.c: In function ‘gdl_dock_object_get_parent_object’: gdl-dock-object.c:498: error: ‘GtkWidget’ has no member named ‘parent’ gdl-dock-object.c:500: error: ‘GtkWidget’ has no member named ‘parent’ make[3]: *** [gdl-dock-object.lo] Error 1 make[3]: Leaving directory `/home/andre/svn-gnome/gdl/gdl' make[2]: *** [all] Error 2
Patch in bug 612572 - adding dependency.
Created attachment 158269 [details] [review] Partial patch gtk+ requirement of this patch is gtk 2.14 only.
Review of attachment 158269 [details] [review]: Thanks! From your comment I guess the bug should be kept open until the rest is fixed?
Review of attachment 158269 [details] [review]: Hmm, actually the patch doesn't apply...
Created attachment 159227 [details] [review] Use accessor functions instead direct access. First patch This is a first patch. Some work is still needed. A cleaner solution for GtkButton::in_button is needed: http://git.gnome.org/browse/gdl/tree/gdl/gdl-dock-item-grip.c#n290
Can this patch get a review?
Sorry, as Javier said "first patch" I assumed there would be a follow-up anyway. Do we have a solution for GtkButton::in_button? Otherwise seems fine.
(In reply to comment #7) > Do we have a solution for GtkButton::in_button? Otherwise seems fine. Johannes, was that a hidden "accepted_commit-now"? ;-)
Review of attachment 159227 [details] [review]: Still not sure about the button thing.
Comment on attachment 159227 [details] [review] Use accessor functions instead direct access. First patch Andre, I've committed your patch for you, hope you dont mind ;) commit fef8d6d96091320917b6ee59c79012f7de3636bf
Created attachment 162864 [details] [review] Partial patch Another partial patch
Review of attachment 162864 [details] [review]: Looks good! What's still missing?
Comment on attachment 162864 [details] [review] Partial patch Committed as http://git.gnome.org/browse/gdl/commit/?id=aee676e13dc344cc80800d2682737c43a459e11b . List of what is still missing is too long to post it here - anybody feel free to compile with -DGSEAL_ENABLE...
Complete list of what is left and needs to be fixed within the next days: gdl/gdl-dock.c: In function ‘gdl_dock_size_request’: gdl-dock.c:564: error: ‘GtkWidget’ has no member named ‘requisition’ gdl/gdl-dock-item.c: In function ‘gdl_dock_item_size_request’: gdl-dock-item.c:789: error: ‘GtkWidget’ has no member named ‘requisition’ gdl/gdl-dock-item-grip.c: In function ‘gdl_dock_item_grip_iconify_clicked’: gdl-dock-item-grip.c:295: error: ‘GtkButton’ has no member named ‘in_button’ gdl/gdl-dock-tablabel.c: In function ‘gdl_dock_tablabel_size_request’: gdl-dock-tablabel.c:308: error: ‘GtkWidget’ has no member named ‘requisition’ gdl/gdl-dock-tablabel.c: In function ‘gdl_dock_tablabel_realize’: gdl-dock-tablabel.c:564: error: ‘GtkWidget’ has no member named ‘style’ gdl-dock-tablabel.c:564: error: ‘GtkWidget’ has no member named ‘style’ gdl-dock-tablabel.c:564: error: ‘GtkWidget’ has no member named ‘window’ gdl/gdl-dock-bar.c: In function ‘gdl_dock_bar_size_vallocate’: gdl-dock-bar.c:530: error: ‘GtkWidget’ has no member named ‘allocation’ gdl-dock-bar.c:562: error: ‘GtkWidget’ has no member named ‘requisition’ gdl/gdl-dock-bar.c: In function ‘gdl_dock_bar_size_hallocate’: gdl-dock-bar.c:762: error: ‘GtkWidget’ has no member named ‘allocation’ gdl-dock-bar.c:796: error: ‘GtkWidget’ has no member named ‘requisition’ gdl/gdl-switcher.c: In function ‘layout_buttons’: gdl-switcher.c:259: error: ‘GtkWidget’ has no member named ‘allocation’ gdl/gdl-switcher.c: In function ‘do_layout’: gdl-switcher.c:434: error: ‘GtkWidget’ has no member named ‘allocation’ gdl/gdl-switcher.c: In function ‘gdl_switcher_size_allocate’: gdl-switcher.c:539: error: ‘GtkWidget’ has no member named ‘allocation’ gdl/test-dock.c: In function ‘save_layout_cb’: test-dock.c:159: error: ‘GtkDialog’ has no member named ‘vbox’
I worked on this yesterday but then realized that the patch from comment #11 broke gdl completely. Will have to revert that and fix the remaining things. It's nothing really difficult but I didn't find out where the former patch broke things exactly.
(In reply to comment #15) > broke gdl completely. Uhm. What does that mean exactly?
@Andre: simply try the gdl/test-dock application - you will end up with an infinite loop of Gtk-Criticals...
Review of attachment 159227 [details] [review]: @Andre: Be more careful next time @me: better review needed... ::: gdl/gdl-dock-object.c @@ +362,3 @@ widget = GTK_WIDGET (object); + if (gtk_widget_get_parent (widget)) + gtk_container_remove (GTK_CONTAINER (gtk_widget_get_parent (GTK_WIDGET (parent))), widget); This should be gtk_widget_get_parent (GTK_WIDGET (parent)) and it's the reason this patch breaks things. Fixed...
Sorry - happens when doing such boring work for hours. :-/
Fixed remaing things in head: http://git.gnome.org/browse/gdl/commit/?id=b3eecbce1e85e1d19da4250f8550a69f09c68cbe