After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612477 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: gnome-nettool
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Germán Poo-Caamaño
Rodrigo Moya
Depends on: 69872
Blocks: 585391
 
 
Reported: 2010-03-10 20:26 UTC by André Klapper
Modified: 2010-04-06 19:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30

Attachments
Make gnome-nettool compile with -DGSEAL_ENABLE (2.75 KB, patch)
2010-03-11 10:31 UTC, André Klapper 		accepted-commit_now Details | Review

Description André Klapper 2010-03-10 20:26:50 UTC 
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

nettool.c: In function ‘netinfo_toggle_state’:
nettool.c:478: error: ‘GtkWidget’ has no member named ‘window’
nettool.c:492: error: ‘GtkWidget’ has no member named ‘window’
nettool.c: In function ‘netinfo_toggle_button’:
nettool.c:532: error: ‘GtkObject’ has no member named ‘flags’
make[2]: *** [nettool.o] Error 1
make[2]: Leaving directory `/home/andre/svn-gnome/gnome-nettool/src'
make[1]: *** [all-recursive] Error 1
Comment 1 André Klapper 2010-03-10 23:39:18 UTC 
Adding dependency to bug 69872 because of GTK_WIDGET_SET_FLAGS
Comment 2 Javier Jardón (IRC: jjardon) 2010-03-11 04:57:38 UTC 
For this:

src/nettool.c:  GTK_WIDGET_SET_FLAGS (button, GTK_CAN_DEFAULT);

You can use 

gtk_widget_set_can_default (GTK_WIDGET (button), TRUE);
Comment 3 André Klapper 2010-03-11 10:31:24 UTC 
Created attachment 155837 [details] [review]
Make gnome-nettool compile with -DGSEAL_ENABLE

bumps gtk+ requirement to 2.19.7 (required for GTK_WIDGET_REALIZED)
Comment 4 Javier Jardón (IRC: jjardon) 2010-03-11 17:44:28 UTC 
Comment on attachment 155837 [details] [review]
Make gnome-nettool compile with -DGSEAL_ENABLE

looks good
Comment 5 Germán Poo-Caamaño 2010-04-06 19:16:05 UTC 
Review of attachment 155837 [details] [review]:

Please, go ahead.

Thanks!
Comment 6 André Klapper 2010-04-06 19:28:46 UTC 
Thanks for the review! Committed:
http://git.gnome.org/browse/gnome-nettool/commit/?id=2e60ec1b6f727c638c7e9518a34ce5e270713dbb