After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611662 - Update documentation for gtkvseparator
Update documentation for gtkvseparator
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 599599
 
 
Reported: 2010-03-03 01:27 UTC by Steven Harms
Modified: 2010-03-04 01:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update documentation for gtkvseparator (3.20 KB, patch)
2010-03-03 01:27 UTC, Steven Harms
needs-work Details | Review
Update documentation for gtkvseparator (3.11 KB, patch)
2010-03-03 23:38 UTC, Steven Harms
none Details | Review
Update documentation for gtkvseparator (3.10 KB, patch)
2010-03-03 23:39 UTC, Steven Harms
committed Details | Review

Description Steven Harms 2010-03-03 01:27:15 UTC
Created attachment 155096 [details] [review]
Update documentation for gtkvseparator

Update documentation per http://live.gnome.org/GTK+/TaskAPIDocMigration
Comment 1 Javier Jardón (IRC: jjardon) 2010-03-03 02:33:44 UTC
Review of attachment 155096 [details] [review]:

Please, remove the trailing whitespaces and fix the commented problems

Otherwise looks good, thank you

::: gtk/gtkvseparator.c
@@ +35,3 @@
+ * @Short_description: A vertical separator
+ * SECTION:gtkvseparator
+/**

Don't use a <variablelist> here, only @See_also: #GtkHSeparator

::: gtk/gtkvseparator.h
@@ +53,3 @@
+ * 
+ * GtkVSeparator:
+/**

Use #GtkVSeparator instead #GtkVSeparator-struct
Comment 2 Steven Harms 2010-03-03 23:38:32 UTC
Created attachment 155179 [details] [review]
Update documentation for gtkvseparator

Fixed trailing whitespace and excess struct comment
Comment 3 Steven Harms 2010-03-03 23:39:54 UTC
Created attachment 155180 [details] [review]
Update documentation for gtkvseparator

Fixed email
Comment 4 Javier Jardón (IRC: jjardon) 2010-03-04 01:36:46 UTC
Comment on attachment 155180 [details] [review]
Update documentation for gtkvseparator

I've modified the commit message a bit to follow the same structure than previous patches

commit 15d1d8bb3b3c408002aaac19566b5d1f23a04aa0
Comment 5 Javier Jardón (IRC: jjardon) 2010-03-04 01:37:11 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thank you Steven.