After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611646 - Calendar shows recurring birthdays incorrectly
Calendar shows recurring birthdays incorrectly
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
: 615497 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-03-02 22:56 UTC by David Ronis
Modified: 2010-04-27 11:54 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
eds patch (555 bytes, patch)
2010-04-12 21:38 UTC, Milan Crha
committed Details | Review
evo patch (4.36 KB, patch)
2010-04-12 21:39 UTC, Milan Crha
committed Details | Review

Description David Ronis 2010-03-02 22:56:48 UTC
The git master's calendar now shows recurring birthdays incorrectly.  Basically, it's taking the birthday (e.g., as given in my addressbook) and displays it as a two day event.  The problem seems to be that the time of the event isn't set properly--namely if the birthday is on March 3, evo thinks it's a 24 hr appointment, starting at 8:00 PM on the 3rd and ending at 8:00 PM on the 4th.
Comment 1 André Klapper 2010-03-03 17:16:32 UTC
Please do not set the GNOME target field when filing bug reports.
Comment 2 Joachim Breitner 2010-03-16 12:58:11 UTC
I can confirm this problem. Here, the calender shows the birthdays starting as lasting from 2am to 2am. Given that I live in Europe, this seems to be a timezone issue: Somewhere, the untimezoned birthday event dates are being shifted due to my current timezone.

This is a regression from 2.28, where it worked.
Comment 3 John Keller 2010-04-11 08:27:31 UTC
I can also confirm this regression from 2.28. Using Evo 2.30.0.1 with existing data, all birthdays are shown at 2:00 AM (I'm in CET +1:00, currently with an additional hour summer time).

The clock in the panel seems to show the birthdays correctly.

As an aside, can I ask why it's necessary to show "all day" for birthdays and anniversaries? (That is, when they're correctly shown at 0:00 midnight.) Of for that matter, a time? That kind of information is redundant for this type of event.
Comment 4 John Keller 2010-04-11 15:25:53 UTC
OK, please ignore my comment about "all day". Just rebooted back into Gnome 2.28, and that doesn't show up in either Evolution or in the panel clock. Must've been my imagination or bad memory...
Comment 5 Ng Oon-Ee 2010-04-12 13:13:31 UTC
I can confirm as well, 2-day events from 8 am to 8 am are created here (I'm in +8 GMT). Setting my timezone to +0 GMT manually fixes it, but then emails sent would be labelled with wrong time stamps and seem to arrive 8 hours late.
Comment 6 Milan Crha 2010-04-12 21:38:45 UTC
Created attachment 158537 [details] [review]
eds patch

for evolution-data-server;

One should be able to call e_cal_set_default_timezone even on an ECal which is not loaded yet. It's used that way on couple places in evolution itself already.
Comment 7 Milan Crha 2010-04-12 21:39:53 UTC
Created attachment 158538 [details] [review]
evo patch

for evolution;

Not every routines opening calendars for UI set the default time zone.
Comment 8 Milan Crha 2010-04-12 21:46:26 UTC
Created commit cf243b3 in eds master (2.31.1+)
Created commit c0855fa in evo master (2.31.1+)

Created commit 687d30b in eds gnome-2-30 (2.30.1+)
Created commit e8745fb in evo gnome-2-30 (2.30.1+)
Comment 9 Ng Oon-Ee 2010-04-12 23:56:54 UTC
Patches applied locally to evo and e-d-s, fixes the issue for me. Birthdays show correctly.
Comment 10 David Ronis 2010-04-13 15:15:54 UTC
Fixed evo & e-d-s now display birthdays properly. 

Thanks Milan.
Comment 11 Milan Crha 2010-04-27 11:54:07 UTC
*** Bug 615497 has been marked as a duplicate of this bug. ***