After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611480 - Provide an alternative for a missing stock-lock and stock-unlock
Provide an alternative for a missing stock-lock and stock-unlock
Status: RESOLVED FIXED
Product: policykit-gnome
Classification: Platform
Component: authorizations tool
unspecified
Other Linux
: Normal major
: ---
Assigned To: policykit-gnome-maint
policykit-gnome-maint
Depends on:
Blocks: 611454
 
 
Reported: 2010-03-01 14:07 UTC by Jakub Steiner
Modified: 2010-06-14 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (786 bytes, patch)
2010-06-14 15:19 UTC, Matthias Clasen
accepted-commit_now Details | Review

Description Jakub Steiner 2010-03-01 14:07:22 UTC
Many apps use the lock icon in many contexts. The two most common ones are 'prevent change' and 'secure channel'. 

We already use the shield metaphor for the secure channel case, I would recommend using either security-medium or security-high for this.

The other case needs to be addressed and the padlock works quite well as a metaphor. I suggest we introduce the following status icons:

changes-prevent
changes-allow

and provide the mapping for stock-lock and stock-unlock
Comment 1 Matthias Clasen 2010-03-01 14:39:54 UTC
Those names sound very appropriate for the use that PolicyKit currenty makes of stock_lock and stock_lock-open, thanks.
Comment 2 Jakub Steiner 2010-03-04 10:48:26 UTC
I just commited the two status icons in gnome-icon-theme which will be released in 2.29.1. 

Stock_lock is already being symlinked to security-medium in icontool though. PolicyKit should look up the new names if the context is more about preventing changes rather than communicating security level.

Reassigning to PolicyKit to make sure the new names are being looked up instead of stock-lock and unlock.
Comment 3 Matthias Clasen 2010-06-14 15:19:12 UTC
Created attachment 163598 [details] [review]
patch

Here is the patch I put in our rawhide package to use the new icons. Ok to commit ?
Comment 4 David Zeuthen (not reading bugmail) 2010-06-14 15:21:19 UTC
Comment on attachment 163598 [details] [review]
patch

Looks great to me. Thanks!
Comment 5 Matthias Clasen 2010-06-14 15:25:53 UTC
committed