After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611087 - [basesink] emergency rendering of late buffers fails after resuming from PAUSE
[basesink] emergency rendering of late buffers fails after resuming from PAUSE
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.27
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-25 15:28 UTC by Mark Nauwelaerts
Modified: 2010-02-26 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix emergency timestamp tracking. (875 bytes, patch)
2010-02-25 15:28 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2010-02-25 15:28:33 UTC 
Created attachment 154694 [details] [review]
Fix emergency timestamp tracking.

Basesink performs emergency rendering of late buffers (about once per second) to avoid playback appearing stuck.  It keeps track of this in last_in_time, but this is reset during state change PLAYING_TO_PAUSED and as a result, emergency rendering never resumes (nor would it ever start if initial buffers are already late).
Comment 1 Sebastian Dröge (slomo) 2010-02-25 17:13:25 UTC 
Should this get into this release? Sounds quite important and I assume it worked better at some point before?
Comment 2 Tim-Philipp Müller 2010-02-26 12:25:20 UTC 
Comment on attachment 154694 [details] [review]
Fix emergency timestamp tracking.

Patch makes sense and should go in, I think
Comment 3 Mark Nauwelaerts 2010-02-26 15:00:51 UTC 
commit 8cdf5a586f93dd81341d13e29d482f171146b7fb
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Fri Feb 26 15:46:50 2010 +0100

    basesink: fix emergency rendering timestamp tracking

    Specifically, if all (including initial) buffers turn up late,
    emergency rendering should also kick in appropriately.

    Fixes #611087.