After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611061 - [mpegtsmux] some buffers are forgotten to push in m2ts_mode
[mpegtsmux] some buffers are forgotten to push in m2ts_mode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.26
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-25 11:02 UTC by dxssx
Modified: 2011-03-26 05:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpegtsmux.c patch (537 bytes, patch)
2010-02-25 11:02 UTC, dxssx 		none Details | Review

Description dxssx 2010-02-25 11:02:48 UTC 
Created attachment 154671 [details] [review]
mpegtsmux.c patch

When m2ts_mode is enabled, the buffer with new_pcr is forgotten to push to adapter or downstream.
see function new_packet_cb.

This will make the ts file discontiguous in counter and make player unhappy.
Comment 1 Jan Schmidt 2011-03-26 05:03:50 UTC 
Fixed in this commit:

commit 1c65ff19f3f22cba88ce769acc9a16ccfd0ba421
Author: Jan Schmidt <thaytan@noraisin.net>
Date:   Sat Mar 26 15:58:21 2011 +1100

    Rewrite M2TS packet output
    
    Make sure we only write the bottom 30 bits of the PCR to the m2ts header.
    Don't use floating point computation for it, and remove weird bit fiddling
    that messes up the PCR in a way I can't find any
    justification/documentation for.
    
    Don't accidentally lose PCR packets from the output.
    
    Fix the description for the m2ts-mode property so it's clear it's a flag,
    and which setting does what.
    
    Fixes: #611061 #644429
    Partially fixes: #645006