After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610813 - Packagekit integration should not rely on session bus detection
Packagekit integration should not rely on session bus detection
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-23 14:05 UTC by Frederic Crozat
Modified: 2010-02-24 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Frederic Crozat 2010-02-23 14:05:33 UTC 
file-roller tries to detect if PackageKit is available by searching for it over dbus session bus. This is incorrect since nowadays, Packagekit is activated on demand by dbus :

using packagekit 0.6.1, file-roller won't be able to use PackageKit unless you manually start gpk-dbus-service
Comment 1 Paolo Bacchilega 2010-02-23 17:20:45 UTC 
I just used the way suggested by the PackageKit author here https://bugzilla.gnome.org/show_bug.cgi?id=482560#c9
Comment 2 Frederic Crozat 2010-02-23 18:59:04 UTC 
I've asked Richard before filling this bug. I guess his comments were based on PackageKit state at the time of his writing ;)

Richard, your comment ?
Comment 3 Richard Hughes 2010-02-23 19:04:51 UTC 
(In reply to comment #1)
> I just used the way suggested by the PackageKit author here
> https://bugzilla.gnome.org/show_bug.cgi?id=482560#c9

Sure, there is a DBus interface, but it's only started when the first thing issues a method. So if you just try to detect if it's there and then never issue a request then the process never gets started :-)

What you need to do is just issue the DBus request like we are doing, and then deal with failure, rather than trying to detect if GPK is on the bus.
Comment 4 Paolo Bacchilega 2010-02-23 22:08:21 UTC 
I removed the call to "NameHashOwner", however the service still doesn't start, the following error is returned: 

"the name org.freedesktop.PackageKit was not provided by any .service files"

on my system (Ubuntu 10.04) the file org.freedesktop.PackageKit.service is located in the folder /usr/share/dbus-1/system-services

any idea?
Comment 5 Frederic Crozat 2010-02-24 10:47:07 UTC 
there are two "services", one system (provided by packagekit) and one session (provided by gnome-package or kpackagekit), in 
/usr/share/dbus-1/services/org.freedesktop.PackageKit.service (with recent enough gnome-packagekit / kpackagekit).

I've tested your patch with latest gnome-packagekit, it works fine (it could be better to change mouse cursor to hour glass while dbus query is running, it can be a little long until you see a window to appear, if packagekit wasn't running already.
Comment 6 Paolo Bacchilega 2010-02-24 12:54:34 UTC 
changed the cursor as well, closing as fixed...