GNOME Bugzilla – Bug 610520
Summary shows/hides after the overview transition
Last modified: 2010-02-20 19:07:24 UTC
Both when entering or leaving the overview, the summary starts to pop out/in after the overview transition has finished - especially the latter case is very noticable (unless for people with very dark backgrounds maybe?). So in my opinion, it looks less intrusive to do both animations at the same time ...
Created attachment 154260 [details] [review] Show/hide the summary during the overview transition Right now, the summary starts popping up when the overview has been shown and starts to disappear when the overview is hidden. Instead, animate the summary during the overview transition.
Comment on attachment 154260 [details] [review] Show/hide the summary during the overview transition >+ (Main.overview.visible && !Main.overview._hideInProgress); the "_" in overview._hideInProgress means that it's a private variable. Agree with the idea of the change though.
Created attachment 154272 [details] [review] Show/hide the summary during the overview transition Yeah, that was kind of expected - updated patch to not use private overview variables in MessageTray.
Comment on attachment 154272 [details] [review] Show/hide the summary during the overview transition yes, better, except that now there's really no reason to be looking at Main.overview.visible at all; just rename the new local variable to "_overviewVisible", and flip the sense of it (set it true in the 'showing' handler and false in the 'hiding' handler), and then in _updateState(), set summarySummoned to "this._pointerInSummary || this._overviewVisible". Go ahead and commit after fixing that.
Attachment 154272 [details] pushed as 1b7c358 - Show/hide the summary during the overview transition