After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610329 - [theoradec] doesn't copy all chroma lines for 4:2:2
[theoradec] doesn't copy all chroma lines for 4:2:2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.27
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-18 05:22 UTC by David Schleef
Modified: 2010-02-21 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description David Schleef 2010-02-18 05:22:19 UTC
Stupid one liner.  Pushing now because when the RM tells me to, I'll be asleep.  Note the mixed width/height:

diff --git a/ext/theora/gsttheoradec.c b/ext/theora/gsttheoradec.c
index 6eef472..ad23bd9 100644
--- a/ext/theora/gsttheoradec.c
+++ b/ext/theora/gsttheoradec.c
@@ -1004,7 +1004,7 @@ theora_handle_image (GstTheoraDec * dec, th_ycbcr_buffer buf, GstBuffer ** out)
 
   for (plane = 0; plane < 3; plane++) {
     width = gst_video_format_get_component_width (format, plane, dec->width);
-    height = gst_video_format_get_component_width (format, plane, dec->height);
+    height = gst_video_format_get_component_height (format, plane, dec->height);
     stride = gst_video_format_get_row_stride (format, plane, dec->width);
 
     dest =
Comment 1 Tim-Philipp Müller 2010-02-18 09:57:01 UTC
Thanks!
Comment 2 Sebastian Dröge (slomo) 2010-02-18 09:58:19 UTC
Not fixed, you forgot to push it :)
Comment 3 Tim-Philipp Müller 2010-02-18 18:00:14 UTC
commit 5685e0a4b79fd730c013e25f01fa754acac5c5c2
Author: David Schleef <ds@schleef.org>
Date:   Wed Feb 17 21:22:54 2010 -0800

    theoradec: Fix chroma copying for 4:2:2
    
    Fix mixup of height/width, causing only half the chroma lines to
    be copied when outputting buffers.  Fixes: #610329.
Comment 4 Sebastian Dröge (slomo) 2010-02-19 04:11:42 UTC
This change breaks the two samples videos at bug #609792 and the rendering of the attach pitivi project (not-linked?!)
Comment 5 David Schleef 2010-02-19 17:33:49 UTC
slomo:

Perhaps you meant a different bug?
Comment 6 Sebastian Dröge (slomo) 2010-02-21 16:55:21 UTC
Must've been some race condition instead, sorry.