GNOME Bugzilla – Bug 610203
Tiled backgrounds are not displayed properly in the overview
Last modified: 2010-02-17 16:26:01 UTC
Tiled backgrounds are not ... well, tiled: http://dl.dropbox.com/u/208391/shell-caps/workspaces.jpeg Before I broke it with the icon-fade-out-in-overview patch, the background was stretched to fill the whole screen, which is obviously less wrong, but still not tiled. The problem is, that while we set up tiling for the root_pixmap actor, we later apply all transformations to its clone.
Created attachment 153971 [details] [review] [Overview] Fix tiled background images Tiled backgrounds are only displayed once in the upper left corner when in the overview - they should be tiled just like outside the overview.
Comment on attachment 153971 [details] [review] [Overview] Fix tiled background images >- background.set_size(global.screen_width, global.screen_height); >+ background.source.set_size(global.screen_width, global.screen_height); This relies on the precise implementation of shell_global_create_root_pixmap_actor(). It would be better to have shell-global.c update global->root_pixmap's size itself as needed.
Created attachment 154043 [details] [review] [Overview] Fix tiled background images OK, moved to shell-global instead. Is it acceptable to put this in emit_screen_size_changed_cb() (doesn't quite fit the name) or should shell-global connect to its own signal (not nice either)? Maybe the callback should be renamed to on_screen_size_changed_cb?
Comment on attachment 154043 [details] [review] [Overview] Fix tiled background images >Maybe the callback should be renamed to on_screen_size_changed_cb? yeah, sounds like a plan
Attachment 154043 [details] pushed as 94d3e27 - [Overview] Fix tiled background images