After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609631 - Add LXDE to OnlyShowIn in desktop files
Add LXDE to OnlyShowIn in desktop files
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-02-11 09:57 UTC by Vincent Untz
Modified: 2010-03-11 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add lxde to onlyshowin (3.91 KB, patch)
2010-02-11 09:57 UTC, Vincent Untz
none Details | Review

Description Vincent Untz 2010-02-11 09:57:09 UTC
Created attachment 153515 [details] [review]
Add lxde to onlyshowin

The LXDE team in openSUSE is working on making sure gnome-keyring works fine in LXDE, and one thing that is needed is to have the keyring autostart apps to autostart in LXDE too.

Here's a patch for this, from Andrea Florio <andrea@opensuse.org>
Comment 1 Stef Walter 2010-02-14 04:35:20 UTC
Committed, but whoops, I just realized I attributed it to the wrong name... Sorry about that Andrea. And thanks for your contributions.
Comment 2 Heiko Baums 2010-03-11 15:13:57 UTC
Unfortunately I can't reopen this bug, so it would be nice, if someone else would do this.
Just adding LXDE to OnlyShowIn is not sufficient because this is also needed in Xfce and other GTK base DEs.

So it would be better to either remove the line OnlyShowIn= completely or to replace it by DontShowIn=KDE.
Comment 3 Vincent Untz 2010-03-11 15:31:36 UTC
I think it's better to complete the OnlyShowIn line: we can't assume all desktops want t use gnome-keyring.

As for XFCE, there's a bug opened about this.
Comment 4 Heiko Baums 2010-03-11 16:15:12 UTC
I haven't found a bug for Xfce.

But I disagree, because I know only one desktop which doesn't depend on GTK (KDE, of course) and I don't know a GTK based desktop which has its own gnome-keyring replacement.
Comment 5 Heiko Baums 2010-03-11 16:17:33 UTC
Ups, have already found it and written a comment for it.
Comment 6 Vincent Untz 2010-03-11 17:07:57 UTC
(In reply to comment #4)
> I haven't found a bug for Xfce.
> 
> But I disagree, because I know only one desktop which doesn't depend on GTK
> (KDE, of course) and I don't know a GTK based desktop which has its own
> gnome-keyring replacement.

What about enligthenment? Also, it's probably wrong to assume that a desktop using GTK+ will necessarily want to use gnome-keyring, even if they don't have a replacement for it.
Comment 7 Heiko Baums 2010-03-11 18:25:18 UTC
I don't know enlightenment - I know it from LiveCDs but haven't installed it yet. But if someone uses a desktop which has its own gnome-keyring replacement it's most likely that he won't install gnome-keyring anyway. So you don't need to care about these desktops.

If a desktop doesn't have its own gnome-keyring replacement it can be assumed that it want to use gnome-keyring, because it's not a question of the desktop but the applications which rely on it. As far as I know network-manager-applet relies on gnome-keyring and network-manager-applet can not only be used on Gnome but also on Xfce, LXDE and other GTK based desktops. And network-manager-applet doesn't care on which desktop it runs.