To Frank and Christian,

This patch looks fine to me (of course I can't comment on the correctness of the German) in general.

However, on line 21:

 (cons 'Ind #("Individual, Joint, etc." "Files Individual German Tax Return"))

I put this in because I didn't know what else to put. 

But it should be in German and correspond to the tax entity type that the codes correspond to. So for example, in the US file the types that there are codes for are: "Individual, Joint, etc.", "Partnership", "Corporation", and "S Corporation". For each of these four, the codes only correspond to Income Taxes.

One of you should replace the English text on this line with the appropriate German text (not simply translate the English text).

Yep, you got me. 

Ok, I believe, there are similar terms in German: "Einzel-, Zusammenveranlagung", "Firma", "GbR". But I fear, the German tax System is somewhat more complex. Some companies are taxed like S companies some like other. Most pay VAT, some small not. Some pay local tax (Gewerbesteuer), special groups (Freiberufler) not. So it is somewhat difficult, to find the right structure here.

I think, in the current state it should read 
(cons 'UStVA #("Mehrwertsteuervoranmeldung" "Erstellt monatliche/(viertel-)jährliche Umsatzsteuervoranmeldung"))
for the VAT declaration of the business accounting template SKR04.
All current keys are related to this.

But probably on long term it would be better, to name the tax entity USt and the form UStVA, because there is another form for the final yearly VAT declaration.

Later I would like to add an entry like
(cons 'ESt #("Einkommensteuererklärung" "Erstellt jährliche Einkommensteuererklärung"))
for the income tax declaration from a new private accounting template.
But before I can finish my first approach of that, I have to play somewhat with  your txf.scm to understand the mechanics better.

So, the patch includes only the changes, were I was quite sure.

Ok, but to avoid any misunderstandings for what you are trying to do going forward, please be aware that the Tax-Entity-Types I set up are intended to be mutually exclusive for a given type of tax system - not to represent different types of tax systems. So, for example, for the currently supported Federal (that is, US national) Income Tax System, the books are for either an individual, a partnership, a corporation, etc. These different types use different tax codes because they file different tax forms. But they are all for US Income Taxes. The Tax-Entity-Type is specified at the book level, not the account level.

Now if in the future we added support for another tax system, say a New York Income Tax set of codes or a California Sales and Use Tax set of codes, this would require that a given account could have no code assigned to it, or possibly a code for US Income Taxes and a separate code for California Sales and Use Taxes, or various combinations thereof. But the Tax-Entity-Type for the books would all be the same for each of these systems. A given tax entity might want to code accounts for US Income Taxes and German VAT.

I point this out because you reference forms for German VAT for now and that later you would like to add support for forms for German income taxes. I don't see how that will work in the current structure.

Comment on attachment 153059 [details] [review]
improve_txf_translation.diff

r18673, thanks!

GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=609043. Please update any external references or bookmarks.