After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608914 - Solid backgrounds may not be drawn
Solid backgrounds may not be drawn
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-03 19:08 UTC by Florian Müllner
Modified: 2010-02-03 20:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Pick up change from gradient to solid background (1.42 KB, patch)
2010-02-03 19:08 UTC, Florian Müllner 		committed Details | Review
[CSS] Test case for solid/gradient background switching (1.14 KB, patch)
2010-02-03 19:09 UTC, Florian Müllner 		rejected Details | Review

Description Florian Müllner 2010-02-03 19:08:50 UTC 
When changing from a gradient to a solid background, the new background
is only drawn if the background color changed as well.
Comment 1 Florian Müllner 2010-02-03 19:08:55 UTC 
Created attachment 152953 [details] [review]
Pick up change from gradient to solid background

On style changes from gradient to solid backgrounds, the new background
must be drawn unconditionally, not depending on whether old and new
background color differ.
Comment 2 Florian Müllner 2010-02-03 19:09:00 UTC 
Created attachment 152954 [details] [review]
[CSS] Test case for solid/gradient background switching
Comment 3 Owen Taylor 2010-02-03 19:31:37 UTC 
Review of attachment 152953 [details] [review]:

Looks good to me, it would be slightly cleaner to move:

+      priv->bg_gradient_type = gradient;

nside the if, rather than just having that outside when it's pretty similar to the other stuff.
Comment 4 Owen Taylor 2010-02-03 19:32:52 UTC 
Review of attachment 152954 [details] [review]:

Marking rejected to get it off of patch review queries, since I don't think it is meant to be committed. An even cooler thing to do for test cases is to extend tests/interactive and include that in the patch with the fix. (Not asking for that here, just a suggestion for the future.)
Comment 5 Florian Müllner 2010-02-03 20:10:19 UTC 
Attachment 152953 [details] pushed as 2b15f38 - Pick up change from gradient to solid background, with the minor modification as suggested by Owen.