GNOME Bugzilla – Bug 608858
Modernize autotools configuration
Last modified: 2010-04-02 22:50:12 UTC
Patch following
See also http://live.gnome.org/GnomeGoals/ModernAutotools
Created attachment 152902 [details] [review] Modernize autotools configuration New requirements: autoconf >= 2.63.2 automake >= 1.10 libtool >= 2.2.6 intltool >= 0.40.0 All these packages are available in debian stable (anyway, notification-daemon depends on GTK+ 2.18, so a recent distribution is needed)
Cool. Thanks for the patch. Looks pretty good. I think my only question is does the gnome compiler warnings thing have at least the same warning checks that we have here?
Hello William, I'm afraid not :( Check the macro source: http://git.gnome.org/browse/gnome-common/tree/macros2/gnome-compiler-flags.m4#n32 Maybe the best solution is make a patch for gnome-commonso so everyone can benefit from the new warnings.
Thanks for checking. That sounds like a good idea. Let's hold off committing this until we fix that one. Behdad is a good source of information for compiler warnings if I recall correctly. Also see: http://mces.blogspot.com/2008/12/year-end-cleaning-ie-on-warning-options.html Thanks!
Though it seems like the other parts of the patch are fine to commit...
Created attachment 152982 [details] [review] Modernize autotools configuration.v2 Hello again, I've modified the patch so still uses gnome-common macros, but check for the flags that are uncovered in gnome-common Also, I've used a separate variable (WARNINGCFLAGS), because CFLAGS is a "user" variable. See this for more info: http://www.gnu.org/software/hello/manual/automake/User-Variables.html#User-Variables
Hmm, autoconf >= 2.63.2 Fedora 12 only has 2.63. Is .2 really needed?
Pushed with the change to only require 2.63.