After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608717 - Segmentation fault when I press delete button
Segmentation fault when I press delete button
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.12.x
Other Linux
: High critical
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2010-02-01 19:31 UTC by Artiom MOLCHANOV
Modified: 2015-12-17 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Artiom MOLCHANOV 2010-02-01 19:31:03 UTC
Open a picture and press delete button closes the application:

gthumb[22750]: segfault at 0 ip 00007f117baac249 sp 00007fff22458470 error 4 in libfile_manager.so[7f117baa6000+d000]
Comment 1 Artiom MOLCHANOV 2010-02-01 19:35:05 UTC
In the browser view "Move to trash" context menu or delete button do the same thing
Comment 2 Paolo Bacchilega 2010-02-01 19:58:56 UTC
I cannot reproduce the problem you describe and without a stack trace from the crash it's very hard to determine what caused it.
Can you get us a stack trace? Please see http://live.gnome.org/GettingTraces for more information on how to do so. Thanks in advance!
Comment 3 Artiom MOLCHANOV 2010-02-01 22:17:24 UTC
While trying to manage the stack trace I can add, that my trash bin is disabled in nautilus. So when I delete something it disappears.
Comment 4 Paolo Bacchilega 2010-02-01 22:34:02 UTC
how did you disable the trash bin?
Comment 5 Artiom MOLCHANOV 2010-02-01 22:42:30 UTC
Starting program: /usr/bin/gthumb 
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffe6fec710 (LWP 11657)]
[New Thread 0x7fffe6f6b710 (LWP 11658)]
[New Thread 0x7fffe6eea710 (LWP 11659)]
[New Thread 0x7fffe6e69710 (LWP 11660)]
[New Thread 0x7fffe6cfc710 (LWP 11661)]
[New Thread 0x7fffe64fb710 (LWP 11662)]
[New Thread 0x7fffe5cfa710 (LWP 11663)]
[Thread 0x7fffe64fb710 (LWP 11662) exited]
[New Thread 0x7fffe64fb710 (LWP 11664)]
[Thread 0x7fffe64fb710 (LWP 11664) exited]
[New Thread 0x7fffe64fb710 (LWP 11665)]
[Thread 0x7fffe64fb710 (LWP 11665) exited]
[New Thread 0x7fffe64fb710 (LWP 11667)]
[Thread 0x7fffe64fb710 (LWP 11667) exited]
[New Thread 0x7fffe64fb710 (LWP 11668)]
[Thread 0x7fffe64fb710 (LWP 11668) exited]
[New Thread 0x7fffe5c59710 (LWP 11669)]
[New Thread 0x7fffe64fb710 (LWP 11670)]
Error: Directory NikonPreview with 8224 entries considered invalid; not read.
[Thread 0x7fffe64fb710 (LWP 11670) exited]

Program received signal SIGSEGV, Segmentation fault.
0x00007fffe980b249 in notify_files_delete () from /usr/lib/gthumb/extensions/libfile_manager.so
(gdb) bt
  • #0 notify_files_delete
    from /usr/lib/gthumb/extensions/libfile_manager.so
  • #1 gth_browser_activate_action_edit_trash
    from /usr/lib/gthumb/extensions/libfile_manager.so
  • #2 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #3 signal_emit_unlocked_R
    from /usr/lib/libgobject-2.0.so.0
  • #4 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #5 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #6 _gtk_action_emit_activate
    from /usr/lib/libgtk-x11-2.0.so.0
  • #7 closure_accel_activate
    from /usr/lib/libgtk-x11-2.0.so.0
  • #8 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #9 signal_emit_unlocked_R
    from /usr/lib/libgobject-2.0.so.0
  • #10 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #11 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #12 gtk_accel_group_activate
    from /usr/lib/libgtk-x11-2.0.so.0
  • #13 gtk_accel_groups_activate
    from /usr/lib/libgtk-x11-2.0.so.0
  • #14 gtk_window_activate_key
    from /usr/lib/libgtk-x11-2.0.so.0
  • #15 gtk_window_key_press_event
    from /usr/lib/libgtk-x11-2.0.so.0
  • #16 _gtk_marshal_BOOLEAN__BOXED
    from /usr/lib/libgtk-x11-2.0.so.0
  • #17 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #18 signal_emit_unlocked_R
    from /usr/lib/libgobject-2.0.so.0
  • #19 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #20 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #21 gtk_widget_event_internal
    from /usr/lib/libgtk-x11-2.0.so.0
  • #22 gtk_propagate_event
    from /usr/lib/libgtk-x11-2.0.so.0
  • #23 gtk_main_do_event
    from /usr/lib/libgtk-x11-2.0.so.0
  • #24 gdk_event_dispatch
    from /usr/lib/libgdk-x11-2.0.so.0
  • #25 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #26 g_main_context_iterate
    from /usr/lib/libglib-2.0.so.0
  • #27 g_main_loop_run
    from /usr/lib/libglib-2.0.so.0
  • #28 gtk_main
    from /usr/lib/libgtk-x11-2.0.so.0
  • #29 main

Comment 6 Artiom MOLCHANOV 2010-02-01 22:46:14 UTC
I don't remember how did I disable it. When I delete something in nautilus I have a message "Cannot move file to the wastebasket, do you want to delete immediately?" I press Yes and it deletes.
Comment 7 Paolo Bacchilega 2010-02-02 11:48:05 UTC
Thank you for your report, the problem you described is fixed now in the current development version and the fix will available in the next public release which will be named 2.11.2
Comment 8 Michael Chudobiak 2010-06-08 12:57:34 UTC
Re-opening: this downstream report has a backtrace showing the same problem with 2.11.3.

http://bugzilla.redhat.com/show_bug.cgi?id=597006

Thread 1 (Thread 7825)

  • #0 notify_files_delete
    at actions.c line 371
  • #1 gth_browser_activate_action_edit_trash
    at actions.c line 458
  • #2 fm__gth_browser_file_list_key_press_cb
    at callbacks.c line 971

Comment 9 Steve Rainwater 2011-05-08 23:12:23 UTC
I get a segfault in thumbnail view if I delete two successive thumbnails. Deleting under other circumstances seems safe though.
Comment 10 Michael Chudobiak 2011-05-09 11:56:38 UTC
Steven,

What version are you using?
Comment 11 Steve Rainwater 2011-05-09 19:51:46 UTC
v2.12.2 running on Fedora 14. I tried to reproduce the problem today and paid careful attention to the sequence of keystrokes. I think I realized what was causing the problem. Here's what happens in detail:

1. Get a thumbnail view of a photo directory
2. click once on a thumbnail near the middle of the list to highlight it
3. hit the delete key
4. hit enter to confirm
5. hit the delete key again to delete next image
6. hit enter again to confirm
7. segfault

What I noticed is that after step 4, gthumb does NOT automatically highlight the next successive image any more. Instead there is no image highlighted after the delete. On step 5, the text of the second confirmation dialog reads "Are you sure you want to move to the trash the 0 selected files?". So if I'd been paying careful attention, I would have seen what was happening. 

The ideal fix would cause give the focus to the next successive image after a delete. But another reasonable focus might be to at least have the delete function check to see if it's deleting 0 images and abort before it segfaults.
Comment 12 Michael Chudobiak 2011-05-10 12:51:50 UTC
This crash is 100% reproducible in the gthumb-2-12 git branch, but seems to be fixed in git master (2.13.x).

- Mike