After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608699 - [oggdemux] memory leak while demuxing
[oggdemux] memory leak while demuxing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.25
Other Linux
: Normal blocker
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-01 17:19 UTC by Massimiliano
Modified: 2010-02-02 09:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Valgrind log with oggdemux leak. (14.71 KB, text/plain)
2010-02-01 17:19 UTC, Massimiliano 		  Details
oggdemux: Don't leak allocated buffers when combined flow return is not OK (1.35 KB, patch)
2010-02-02 09:20 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Massimiliano 2010-02-01 17:19:16 UTC 
Created attachment 152741 [details]
Valgrind log with oggdemux leak.

Running a sample chain, I noticed some memory was leaked. The test chain used to produce the report was:

gst-launch filesrc location=/usr/share/sounds/gnome/default/alerts/sonar.ogg ! oggdemux ! fakesink

Attached you will find valgrind log.
Comment 1 Sebastian Dröge (slomo) 2010-02-02 08:10:15 UTC 
Yes, there are some cases when the buffer can leak. I'll work on that later
Comment 2 Sebastian Dröge (slomo) 2010-02-02 09:20:44 UTC 
Created attachment 152816 [details] [review]
oggdemux: Don't leak allocated buffers when combined flow return is not OK

Fixes bug #608699.
Comment 3 Sebastian Dröge (slomo) 2010-02-02 09:21:36 UTC 
Tim, could we get this into 0.10.26? The patch is quite trivial ;)
Comment 4 Sebastian Dröge (slomo) 2010-02-02 09:24:25 UTC 
Actually this also happens if the packet is a BOS and we're not pushing headers (line 648)
Comment 5 Sebastian Dröge (slomo) 2010-02-02 09:32:41 UTC 
commit 39f97aa7288b416a65a600af58fee8c1cbc6b9c4
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Feb 2 10:18:05 2010 +0100

    oggdemux: Don't leak allocated buffers
    
    This can happen if the combined flow return is not OK although the
    allocation succeeded or if the packet in question is a BOS and we're
    not going to push headers.
    
    Fixes bug #608699.