After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608651 - dshowvideosink.cpp crash
dshowvideosink.cpp crash
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.17
Other Windows
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-01 04:47 UTC by David Hoyt
Modified: 2010-02-02 00:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dshowvideosink.cpp patch (901 bytes, patch)
2010-02-01 04:47 UTC, David Hoyt 		accepted-commit_now Details | Review
dshowvideosink.cpp patch (782 bytes, patch)
2010-02-01 05:12 UTC, David Hoyt 		none Details | Review

Description David Hoyt 2010-02-01 04:47:28 UTC 
Created attachment 152704 [details] [review]
dshowvideosink.cpp patch

dshowvideosink will crash sometimes if it encounters an unknown format. According to MSDN: "In any function that receives an AM_MEDIA_TYPE parameter, always validate the values of cbFormat and formattype before dereferencing the pbFormat member."

I attached a patch and an example video (dnxhd test from FFmpeg) that causes gst to crash on windows using this sink.
Comment 1 David Hoyt 2010-02-01 04:49:58 UTC 
The sample video was too large to attach. Run make check from a newer ffmpeg build and then use <FFmpeg build tree>/tests/data/a-dnxhd-1080i.mov.
Comment 2 David Hoyt 2010-02-01 05:12:57 UTC 
Created attachment 152706 [details] [review]
dshowvideosink.cpp patch
Comment 3 Michael Smith 2010-02-01 21:30:52 UTC 
Review of attachment 152704 [details] [review]:

Looks fine. Should take this.
Comment 4 Michael Smith 2010-02-02 00:26:59 UTC 
commit 584ac24ba01f0f33e4f2732c1a5b2da7769e79ab
Author: David Hoyt <dhoyt@llnl.gov>
Date:   Mon Feb 1 16:26:36 2010 -0800

    dshowvideosink: don't crash on invalid AM_MEDIA_TYPE