GNOME Bugzilla – Bug 608268
[flvmux] index timestamps should be in seconds, not milliseconds
Last modified: 2010-01-27 20:54:52 UTC
Apparently the flv index used to be specified in the official flv format 1 documents. I can no longer find it, but there are multiple references available on the web [1][2] that state the timestamps in the index should be in seconds. Our own demuxer also expects the timestamps to be in seconds. Currently our muxer writes them in milliseconds. [1] http://74.125.77.132/search?q=cache:4eLMxiEVIw4J:svn.red-bean.com/bob/flashticle/trunk/flashticle/scripts/flvinfo.py+flv+filepositions+times+seconds&cd=3&hl=en&ct=clnk&gl=uk [2] http://www.buraks.com/captionate/helpfile/e05.html A patch is coming shortly...
Created attachment 152429 [details] [review] Add timestamps to the index in seconds not milliseconds
Comment on attachment 152429 [details] [review] Add timestamps to the index in seconds not milliseconds Looks fine, please push, thanks!
Sorry for not putting the bug number in the commit message. Module: gst-plugins-good Branch: master Commit: f9bf5970a306940045cd94c9380bb79148775cc9 URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=f9bf5970a306940045cd94c9380bb79148775cc9 Author: Robert Swain <robert.swain@collabora.co.uk> Date: Wed Jan 27 17:53:07 2010 +0100 flvmux: index timestamps should be in seconds, not milliseconds --- gst/flv/gstflvmux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gst/flv/gstflvmux.c b/gst/flv/gstflvmux.c index e1cb143..2d4b817 100644 --- a/gst/flv/gstflvmux.c +++ b/gst/flv/gstflvmux.c @@ -544,7 +544,7 @@ gst_flv_mux_push (GstFlvMux * mux, GstBuffer * buffer) GstFlvMuxIndexEntry *entry = g_slice_new (GstFlvMuxIndexEntry); entry->position = mux->byte_count; entry->time = - gst_guint64_to_gdouble (GST_BUFFER_TIMESTAMP (buffer)) / GST_MSECOND; + gst_guint64_to_gdouble (GST_BUFFER_TIMESTAMP (buffer)) / GST_SECOND; mux->index = g_list_prepend (mux->index, entry); }