GNOME Bugzilla – Bug 608245
segmentation fault in gst-rtsp-server
Last modified: 2010-01-27 17:44:16 UTC
Created attachment 152394 [details] [review] segmentation fault in server side Hi, I found a segmentation fault in gst-rtsp-server.When the client side network is disabled and then re-enabled the network ,getting segmentation fault in server side.I think it is because of non handling of client dispatch in server side.(gst-plugin-base/gst-libs/gst/rtsp/gstrtspconnection.c). when client side dispatched and then enabled, the return value is GST_RTSP_ESYS .And if gst_rtsp_source_dispatch() function falling to goto error; and return FALSE, it makes a segmentation fault. But if server side network is disabled and reenabled then it will fallto write_blocked; and it returns TRUE. so no problem there.
I attached a diff file here to avoid the segmentation fault .
Created attachment 152395 [details] gdb output of segmentation fault gdb output
Comment on attachment 152394 [details] [review] segmentation fault in server side patch to avoid the segmentation fault
Your patch seems to make it ignore errors. I don't know why it crashes but it could be because the RTSP server does not implement an error_full function and if the memory is uninitialized this could result in calling bad code and crashing. Try this patch in rtsp-server and reopen if that doesn't fix it: commit ce6724f788ceac7b95a523d379f27b2d863ed605 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Wed Jan 27 18:38:27 2010 +0100 rtsp-client: implement error_full Implement error_full to avoid some segfaults when the rtspconnection calls it. See #608245