After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607615 - Make it possible to favor new sources in case of SSRC conflict
Make it possible to favor new sources in case of SSRC conflict
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-20 23:09 UTC by Olivier Crête
Modified: 2010-03-10 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtpsession: Move SSRC conflicts lists into RTPSource (9.18 KB, patch)
2010-01-20 23:09 UTC, Olivier Crête
none Details | Review
rtpsession: Make it possible to favor new sources in case of SSRC conflict (8.93 KB, patch)
2010-01-20 23:09 UTC, Olivier Crête
none Details | Review
rtpsession: Make it possible to favor new sources in case of SSRC conflict (9.48 KB, patch)
2010-01-21 21:36 UTC, Olivier Crête
none Details | Review

Description Olivier Crête 2010-01-20 23:09:53 UTC
The current code favors the old source address if there is a remote ssrc conflict detected. In the case of 1 to 1 VoIP calls, it seems to opposite behavior is preferred. RFC 3550 suggests that the correct strategy depends on the use-case, hence making it a property.
Comment 1 Olivier Crête 2010-01-20 23:09:55 UTC
Created attachment 151889 [details] [review]
rtpsession: Move SSRC conflicts lists into RTPSource

We will also need to track SSRC conflicts in remote sources.
Comment 2 Olivier Crête 2010-01-20 23:09:59 UTC
Created attachment 151890 [details] [review]
rtpsession: Make it possible to favor new sources in case of SSRC conflict

Add a "favor-new" property that tells the session to favor new sources when
there is a SSRC conflict. This is useful for SIP calls and other such cases
where a remote loop is extremely unlikely.
Comment 3 Olivier Crête 2010-01-21 00:14:00 UTC
This may also interest the Tandberg guys.
Comment 4 Olivier Crête 2010-01-21 21:36:04 UTC
Created attachment 151967 [details] [review]
rtpsession: Make it possible to favor new sources in case of SSRC conflict

Updated with a bit more debug (not sure if its a great idea), but it did help me find the source
of a server bug (but there is overhead of every packet).
Comment 5 Wim Taymans 2010-03-05 15:15:23 UTC
will push after the freeze
Comment 6 Wim Taymans 2010-03-10 10:36:58 UTC
commit a6dfe961690d30013bdff29f2dbfc8e708edef75
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Fri Mar 5 16:08:45 2010 +0100

    rtpsession: Make it possible to favor new sources in case of SSRC conflict
    
    Add a "favor-new" property that tells the session to favor new sources when
    there is a SSRC conflict. This is useful for SIP calls and other such cases
    where a remote loop is extremely unlikely.
    
    Fixes #607615

commit f336ea283feaaf2d67985b41af0544dbc3a26c2c
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Fri Mar 5 15:46:48 2010 +0100

    rtpsession: Move SSRC conflicts lists into RTPSource
    
    We will also need to track SSRC conflicts in remote sources.
    
    See #607615