After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607116 - [playbin2] no 'about-to-finish' signal with audio CDs
[playbin2] no 'about-to-finish' signal with audio CDs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-16 00:24 UTC by regomodo
Modified: 2010-01-22 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description regomodo 2010-01-16 00:24:24 UTC 
Unlike with 'file://' uri's where an 'about-to-finish' is emitted near it's finish during playback, 'cdda://' sources have no such signal.

Instead gst.MESSAGE_EOS message-type from the 'message' 
signal is only available.

This makes gapless-playback with audio-cds impossible.
Comment 1 Tim-Philipp Müller 2010-01-16 11:55:52 UTC 
This is surely not python-specific?
Comment 2 regomodo 2010-01-16 13:56:23 UTC 
(In reply to comment #1)
> This is surely not python-specific?

I've no idea how to try it out in any other form be it gst-launch or C code.
Comment 3 regomodo 2010-01-20 18:59:25 UTC 
Is there anything I can do to help? I really need this feature.
Comment 4 Wim Taymans 2010-01-22 11:26:31 UTC 
It's because for cdda we don't use decodebin2, which should provide us with the about-to-finish signal. Will need to do something similar for raw sources.
Comment 5 Wim Taymans 2010-01-22 15:37:19 UTC 
commit 12af63394225526e0d98267978007e726040dc2f
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Jan 22 16:23:43 2010 +0100

    uridecodebin: handle raw sources about-to-finish signals
    
    When we are dealing with a source that produces raw audio/video, we don't use a
    decodebin2 to decode the data and we thus don't have the drained/about-to-finish
    signal emited. To fix this, we add a padprobe on the source pads and emit the
    drained signal ourselves. This then makes playbin2 emit the about-to-finish
    signal for raw sources such as cdda://
    
    Fixes #607116
Comment 6 regomodo 2010-01-22 21:26:04 UTC 
Thanks Wim. The patch you just put through works for me.