After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606962 - availability of gnomespeech not handled in orca preferences (console and GUI)
availability of gnomespeech not handled in orca preferences (console and GUI)
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.29.x
Other All
: Normal major
: ---
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-14 14:53 UTC by Halim Sahin
Modified: 2010-01-19 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the log fof the traceback (1.24 KB, text/plain)
2010-01-14 14:53 UTC, Halim Sahin
  Details
Patch to catch exceptions in speech.init (1.01 KB, patch)
2010-01-14 17:01 UTC, Willie Walker
committed Details | Review
Patch to fix issue with GUI (1.10 KB, patch)
2010-01-14 20:00 UTC, Willie Walker
committed Details | Review
output of the new traceback (619 bytes, text/plain)
2010-01-19 10:40 UTC, Halim Sahin
  Details

Description Halim Sahin 2010-01-14 14:53:56 UTC
Created attachment 151400 [details]
the log fof the traceback

I have tested the new at-spi dbus stuff and had the following problem:
I've installed orca from git with no errors.
After starting orca i got a trackeback which shows a hard dependency to gnomespeech.
This should be checked in orca and in my opinion gnomespeech should be optional.
For gnome 3.0 gnomespeech is deprecated so it would be the best to remove it's dependency from orca competely.

See the attachment which contains the traceback
Comment 1 Willie Walker 2010-01-14 17:01:38 UTC
Created attachment 151409 [details] [review]
Patch to catch exceptions in speech.init
Comment 2 Willie Walker 2010-01-14 17:08:58 UTC
There are two separate, but related, issues here:

1) The orca console setup crashes if gnome-speech is not available.
2) At some point, gnome-speech *might* be deprecated.

For #2, I've opened bug #606975.  I'll use this current bug to address #1.

> For gnome 3.0 gnomespeech is deprecated so it would be the best to remove it's
> dependency from orca competely.

The goal is to be able to deprecate gnome-speech in favor of SpeechDispatcher.  Until we're ready to make the full transition to SpeechDispatcher, we'll need to stay with gnome-speech as the default solution to use if you request speech with Orca.

Note that the reference to gnome-speech is somewhat of a "soft" reference in Orca -- there's no specific hard import of the gnome-speech factory.  Instead, it is referred to in the settings.py:speechFactoryModules and settings.py:speechServerFactory settings.  Because gnome-speech is still the supported speech solution for orca, the default values still refer to gnome-speech and they will remain this way until bug #606975 is addressed.

I believe this specific problem can be isolated to just the console preferences configuration.  Unlike when Orca is run normally, the console preferences setup is not handling failures in the initialization of speech properly and is crashing.  I put a try/except around the call to speech.init() in the console prefs code to prevent the console preferences application from crashing.  That should close this bug.

Another thing we might try is providing some sort of autodetection code in Orca.  With this, Orca would try the preferred solution first, but then look at the speechServerModules list and try them in order until it found something that worked.  I've opened bug #606978 for that enhancement.

Thanks!
Comment 3 Willie Walker 2010-01-14 19:38:19 UTC
Reopening - in experimenting with this more, the failure prevents the GUI preferences from coming up.
Comment 4 Willie Walker 2010-01-14 20:00:09 UTC
Created attachment 151422 [details] [review]
Patch to fix issue with GUI
Comment 5 Halim Sahin 2010-01-19 10:40:10 UTC
Created attachment 151749 [details]
output of the new traceback