GNOME Bugzilla – Bug 606420
Support for application-indicators/StatusNotifierIcon
Last modified: 2018-09-21 16:58:25 UTC
We would like to support application-indicators for Brasero as proposed at this page: https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators The Canonical DX team will provide a patch to vino, but the work has not started, so I wanted to open this bug as a placeholder and to get feedback on the feature, thanks!
Bah sorry for the mistake, the Canonical DX team will be providing a patch for /brasero/ for this feature.
Created attachment 155230 [details] [review] Patch for supporting Application indicators This patch is against the BRASERO_2_29_91 tag, as that is the version in Ubuntu Lucid Lynx, but I have successfully rebased it on top of git HEAD as well.
Attached is a patch for support for Application Indicators, it was initially vetted and discussed on Launchpad: https://bugs.launchpad.net/ubuntu/+source/brasero/+bug/497853 As it stands, I realize this patch is not yet ideal. I have chose to implement the patch in this way as it is the least invasive I could figure out. My goals were: - support application indicators - make the patch acceptable to upstream - in that vein, make it maintainable for both the Canonical team (realizing we would maintain the patch for Lucid, as it is passed the Gnome release deadline) and upstream developers - support not removing any existing functionality (namely, the current implementations using GtkStatusIcon) if the particular target does not have the application indicator libraries. Unfortunately, as is, the patch does not completely meet these to my satisfaction. The way in which I implemented it was by copying the code for BraseroTrayIcon in brasero-tray.c to BraseroAppIndicator in brasero-app-indicator.c and then changing things to work with application indicators. Obviously, this is an issue because there is shared code (particularly from brasero_tray_icon_set_tooltip () and brasero_tray_icon_set_progress ()) that is copy and pasted. It didn't make sense to have BraseroAppIndicator inherit from BraseroTrayIcon because BraseroTrayIcon inherits from GtkStatusIcon and BraseroAppIndicator is not a status icon. I'm not sure what other appropriate means of abstraction I could use for sharing this and making things maintainable. I have brought this forward for your review for advice on how this might be more acceptable for inclusion (even eventual) into Brasero. The big thing would be what would be the proper way to make this more maintainable while still supporting both GtkStatusIcon and App Indicators as possible targets.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/brasero/issues/88.