After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606322 - audiofirfilter: Add support for changing kernel size without draining the sample history
audiofirfilter: Add support for changing kernel size without draining the sam...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-07 16:30 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-03 14:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audiofxbasefirfilter: property for not draining on changes (4.77 KB, patch)
2010-01-07 16:36 UTC, Sebastian Dröge (slomo) 		needs-work Details | Review
WIP audiofxbasefirfilter (4.39 KB, patch)
2010-01-07 16:36 UTC, Sebastian Dröge (slomo) 		needs-work Details | Review

Description Sebastian Dröge (slomo) 2010-01-07 16:30:13 UTC 
It would be nice if draining the history could be prevented when changing the kernel size too. Currently it's only supported if the kernel size stays the same.

Following are some patches that partially implement this and some notes on what still needs to be done.
Comment 1 Sebastian Dröge (slomo) 2010-01-07 16:36:21 UTC 
Created attachment 150979 [details] [review]
audiofxbasefirfilter: property for not draining on changes

Adds a new property for not draining the buffers when the
kernel changes
Comment 2 Sebastian Dröge (slomo) 2010-01-07 16:36:29 UTC 
Created attachment 150980 [details] [review]
WIP audiofxbasefirfilter
Comment 3 Sebastian Dröge (slomo) 2010-01-07 16:38:12 UTC 
What still needs to be done:
- When the kernel size decreases, process the oldest samples from the history and push output downstream
- Copy the *last* samples of the history instead of the first in FFT mode
- Convert the buffer when switching from FFT mode to non-FFT mode
Comment 4 Tim-Philipp Müller 2014-11-28 20:37:18 UTC 
After almost five years, this should probably be merged or closed :)
Comment 5 GStreamer system administrator 2018-11-03 14:40:31 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/19.