After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606266 - build error, usage of deprecated GTK_WIDGET_TOPLEVEL
build error, usage of deprecated GTK_WIDGET_TOPLEVEL
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
: 606274 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-01-06 21:57 UTC by Frederic Peters
Modified: 2010-01-07 01:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Frederic Peters 2010-01-06 21:57:37 UTC 
GTK_WIDGET_TOPLEVEL has recently been marked as deprecated, this causes the
build to fail with current GTK+ master.

gtk.o: In function `finc_activate_cb':
/scratch/jhbuild/src/gcalctool/src/gtk.c:683: undefined reference to `GTK_WIDGET_TOPLEVEL'
collect2: ld returned 1 exit status

/**
 * GTK_WIDGET_TOPLEVEL:
 * @wid: a #GtkWidget.
 *
 * Evaluates to %TRUE if the widget is a toplevel widget.
 *
 * Deprecated: 2.20: Use gtk_widget_is_toplevel() instead.
 */
Comment 1 Robin Sonefors (ozamosi) 2010-01-07 01:11:50 UTC 
*** Bug 606274 has been marked as a duplicate of this bug. ***
Comment 2 Robin Sonefors (ozamosi) 2010-01-07 01:18:49 UTC 
Thank you for reporting.

I've fixed this in http://git.gnome.org/browse/gcalctool/commit/?id=e5ffafc77ac0e1ddc72d802bd411561eaed532b8

Instead of going the #ifdef route suggested in bug 606274, I bumped our required GTK version - we were already depending on 2.17, so the oldest stable GTK version that was usable with gcalctool was already 2.18, which is when gtk_widget_is_toplevel was introduced.