After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606162 - Unnecessarily word wrapped description
Unnecessarily word wrapped description
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: Graphing / Charting
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-01-05 22:25 UTC by Andreas J. Guelzow
Modified: 2010-01-14 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of the bottom of the graph guru (8.48 KB, image/png)
2010-01-06 15:33 UTC, Andreas J. Guelzow
  Details
change the text alignment (923 bytes, patch)
2010-01-07 21:22 UTC, Jean Bréfort
none Details | Review
implement tooltips for subtypes (2.55 KB, patch)
2010-01-12 16:03 UTC, Jean Bréfort
committed Details | Review

Description Andreas J. Guelzow 2010-01-05 22:25:37 UTC
plugins/plot_pie/plot-types.xml.in:       _description="Percentage of each contributor displayed in ring for each serie."
plugins/plot_pie/plot-types.xml.in:       _description="Percentage of each contributor displayed in ring for each serie with wedges of the last ring split apart."


I think "serie" should be "series". The former word does not exist.

Note also that many of these descriptors are unnecessarily split into two lines in Gnumeric's chart selector description filed. I don't know where that is caused.
Comment 1 Jean Bréfort 2010-01-06 10:24:37 UTC
I agree that it's a typo. Fell free to fix that.

I don't understand what is split?
Comment 2 Andreas J. Guelzow 2010-01-06 15:33:40 UTC
Created attachment 150896 [details]
screenshot of the bottom of the graph guru

In the screen shot you see that the descriptive text does not fill the width of thebox but miraculously is split early.
Comment 3 Andreas J. Guelzow 2010-01-06 15:45:40 UTC
typo is fixed.
Comment 4 Jean Bréfort 2010-01-06 16:26:11 UTC
The split comes from GTK+. I'll try to find a way to force GTK+ to adopt a more senseful behavior (not sure it's possible).
Comment 5 Andreas J. Guelzow 2010-01-06 16:42:26 UTC
I am not sure where the dialog is created, but I suspect that the textview in place does not have horizontal fill&expand set.
Comment 6 Jean Bréfort 2010-01-06 16:48:24 UTC
It's a GtkLabel inside a GtkFrame, there is no fill/expand property there.

Quoting Gtk+ docs:
Note that setting line wrapping to TRUE does not make the label wrap at its parent container's width, because GTK+ widgets conceptually can't make their requisition depend on the parent container's size. For a label that wraps at a specific position, set the label's width using gtk_widget_set_size_request().
Comment 7 Andreas J. Guelzow 2010-01-06 17:05:38 UTC
Jean, where are you creating this GtkLabel? I do dialogs.
Comment 8 Jean Bréfort 2010-01-06 17:16:26 UTC
graph_guru_type_selector_new using GtkBuilder
Comment 9 Jean Bréfort 2010-01-07 21:22:28 UTC
Created attachment 150999 [details] [review]
change the text alignment

We have a better alignment with this patch, but if the dialog is widened, the text layout does not change. Clearly GtkLabel has problems with multiline text.
Comment 10 Andreas J. Guelzow 2010-01-10 01:22:33 UTC
Jean, what would you think of making the text of the description a tool tip to the list item. I think the text is useful only for beginning users anyways, so it may be ideal for a tooltip. This would also give much more space in the dialog to show the preview permanently (bug #495781).
Comment 11 Andreas J. Guelzow 2010-01-10 01:25:41 UTC
Considering that there is gtk_tree_view_set_tooltip_column (), implementing the tooltips for the treeeview should be quite easy.
Comment 12 Andreas J. Guelzow 2010-01-10 01:28:19 UTC
I just realized that the text changed for the subtypes. So we might need anotehr tooltip explaining the subtypes.
Comment 13 Jean Bréfort 2010-01-12 16:03:49 UTC
Created attachment 151260 [details] [review]
implement tooltips for subtypes

If we go this way, GogGuru needs some surgery.
Comment 14 Jean Bréfort 2010-01-12 16:10:59 UTC
Comment on attachment 151260 [details] [review]
implement tooltips for subtypes

Now, I need to change the UI to remove the label.
Comment 15 Jean Bréfort 2010-01-14 10:11:56 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.