GNOME Bugzilla – Bug 606050
Implement ptime support
Last modified: 2010-01-05 18:24:51 UTC
I'm attaching two series of patches (against base and good). In base, I check if "maxptime" is in the downstream caps in GstBaseRTPPayload and use that on top of the propety. I also get the "ptime" from the caps and store it. In GstBaseRTPAudioPayload, I respect the ptime (by forcing the min and max size to be exactly what was requested). In good, I implement the same thing for the G.729 payloader. I also simplified the usage of the GstAdapter in the g.729 payloader (hopefully making it more readable.. I wrote it and it took me a while to figure out how it works..).
Created attachment 150790 [details] [review] basertppayload: Accept maxptime from caps
Created attachment 150791 [details] [review] rtpbasepayload: Store ptime from caps
Created attachment 150792 [details] [review] basertpaudiopayload: Respect ptime if it is given If the ptime is given in the caps, respect it and force the minimum and maximum sizes to be exactly the requested ptime.
Created attachment 150793 [details] [review] rtp: Add maxptime to the README
Created attachment 150794 [details] [review] rtpg729pay: Support ptime from caps
Created attachment 150795 [details] [review] rtpg729pay: Simplify adapter usage
Created attachment 150796 [details] [review] tests: Add G.729 RTP payloader/depayloader test
please commit.
BASE: commit bc6179952b292110964e808b16ae127be5b221f9 Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Tue Dec 29 18:45:32 2009 -0500 basertpaudiopayload: Respect ptime if it is given If the ptime is given in the caps, respect it and force the minimum and maximum sizes to be exactly the requested ptime. https://bugzilla.gnome.org/show_bug.cgi?id=606050 commit a4b0f2a1bd0fbea6b5ab4c6673f15fe37c824eb9 Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Tue Dec 29 18:36:29 2009 -0500 rtpbasepayload: Store ptime from caps https://bugzilla.gnome.org/show_bug.cgi?id=606050 commit 21151ba9407bca2f37a8e7e25ead0ca9d183f30f Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Wed Dec 2 19:40:58 2009 +0530 basertppayload: Accept maxptime from caps https://bugzilla.gnome.org/show_bug.cgi?id=606050 GOOD: commit e8dcea17fcdd27dd9184d46ad43e071ba202cbbf Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Thu Dec 31 17:09:03 2009 -0500 tests: Add G.729 RTP payloader/depayloader test https://bugzilla.gnome.org/show_bug.cgi?id=606050 commit 63a9db5826a88fd6153b45f5048f7ad57273b6f8 Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Thu Dec 31 16:52:30 2009 -0500 rtpg729pay: Simplify adapter usage https://bugzilla.gnome.org/show_bug.cgi?id=606050 commit 0a1858779294c091c4022837f5dfab2928dfebed Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Thu Dec 31 16:27:30 2009 -0500 rtpg729pay: Support ptime from caps https://bugzilla.gnome.org/show_bug.cgi?id=606050 commit 321829f5953f13701c558866f144751bc7cbe443 Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Wed Dec 2 19:35:21 2009 +0530 rtp: Add maxptime to the README https://bugzilla.gnome.org/show_bug.cgi?id=606050