After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606009 - weirdness with clipping in abiword - csw
weirdness with clipping in abiword - csw
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.18.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
csw
Depends on:
Blocks:
 
 
Reported: 2010-01-04 12:23 UTC by Martin Sevior
Modified: 2010-01-25 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Martin Sevior 2010-01-04 12:23:55 UTC
abiword-2.8 when built with gtk-2.18 displaying annoying pixel dirt. The bug is noticeable after loading a document of more than one page. The left ruler is wrongly drawn.

In addition holding down the "down" arrow key when scrolling through a document longer than one screen leaves a trail of lines marking the position of the carat on the line before.

These bugs are obvious in the version of abiword released with Fedora-12.

These bugs are not present in abiword-2.8 built with gtk-2.16 (such as in Fedora 11).

My guess is that these bugs are related to issues we have with setting and removing the clip region using cairo_clip(m_cr) and cairo_reset_clip(m_cr)

AbiWord does not use a double buffered drawing region. Maybe the bugs are related to that?
Comment 1 Javier Jardón (IRC: jjardon) 2010-01-04 16:18:37 UTC
Hello Martin,

Do you see the problem when use GDK_NATIVE_WINDOWS env variable ( see http://library.gnome.org/devel/gtk/stable/gtk-running.html )?
Comment 2 Martin Sevior 2010-01-04 20:24:25 UTC
Hi Javier,

I just tried:

export GDK_NATIVE_WINDOWS=1

ran AbiWord and confirmed the presence of the bug as described.
Comment 3 Matthias Clasen 2010-01-07 14:35:17 UTC
Alex, can you have a look at this ?
Comment 4 Alexander Larsson 2010-01-19 14:07:46 UTC
The caret redraw issue is fixed by:

http://git.gnome.org/browse/gtk+/commit/?id=841fa4771505b6810da341ea379d5f56af7ef1d1
Comment 5 Alexander Larsson 2010-01-19 14:52:19 UTC
Additionally it fixes most of the left-ruler graphics errors. However by holding down the mouse button and moving the scrollbar around i'm sometimes able to create a situation where some of the digits in the ruler are partially not drawn.

Is this a regression? I'm currently unable to test with the old gtk.
Comment 6 Martin Sevior 2010-01-24 13:08:53 UTC
Hi Alex,

Awesome! thanks very much. The bug with not drawing the numbers on vertical scroll is present in gtk which comes with F12.

Cheers

Martin
Comment 7 Martin Sevior 2010-01-24 13:33:51 UTC
To be clear, you have not made a regression.

Cheers

Martin
Comment 8 Patrik Fimml 2010-01-24 13:42:17 UTC
Note that most of the left-ruler drawing issues were caused by abiword drawing to the surface outside of expose. Properly using queue_draw_area() instead solved most issues.
Comment 9 Alexander Larsson 2010-01-25 12:00:06 UTC
Marking this fixed then