After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605882 - rtpg723pay is incorrect
rtpg723pay is incorrect
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-02 04:30 UTC by Olivier Crête
Modified: 2010-02-11 21:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Olivier Crête 2010-01-02 04:30:48 UTC 
I was just reading RFC 3551 (section 4.5.3). I noticed that G.723 does not have 2 different types of frames, but 3. And that they can be intermixed in any way you want. So you have to look at the first 2 bits of the frame to know the size. 

So the rtpg723pay element in the tree is incorrect as it assume thats the same rules as for G.729 can be applied. We should either fix it or remove it before the next release.
Comment 1 Wim Taymans 2010-01-05 17:36:22 UTC 
Can someone test this?

commit d6d06630e8e1d9f60794791766597c9c12c337e2
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue Jan 5 18:33:25 2010 +0100

    rtpg723pay: rewrite payloader
    
    Handle all 3 packet sizes according to RFC 3551.
    Totally untested, we don't have a G723 encoder.
    
    Fixes #605882
Comment 2 tiagokatcipis 2010-02-11 20:57:54 UTC 
i can try to fix it, but i might have problems testing with diferent types of frames, the encoder i can use to test works only with one of the frame types.
Comment 3 tiagokatcipis 2010-02-11 21:06:34 UTC 
ops, sorry, now that i realized that it is already implemented and there is only testing left to be made, i will see if i can get a encoder that can test the 3 frame types (i think the one i have at my work will only encode 2 frame types, or only one).