After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605313 - Use totem_pl_parser_save()
Use totem_pl_parser_save()
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 611138 (view as bug list)
Depends on: 604909
Blocks: 375665
 
 
Reported: 2009-12-23 15:48 UTC by Carlos Garnacho
Modified: 2010-02-26 02:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (7.63 KB, patch)
2009-12-23 15:48 UTC, Carlos Garnacho
committed Details | Review

Description Carlos Garnacho 2009-12-23 15:48:57 UTC
Created attachment 150302 [details] [review]
patch

Bug #604909 proposes replacing write API so it doesn't depend on GTK+, Here is
a patch for this project to use the newer API in case it gets committed
Comment 1 Bastien Nocera 2010-01-08 14:09:58 UTC
I'd expect Jonathan to want to support both the old and the new APIs. The new code is in totem-pl-parser 2.29.1. Could you please update your patch for that?
Comment 2 Jonathan Matthew 2010-01-09 01:28:30 UTC
Right, we can't depend on such a new version of totem-pl-parser yet.
Comment 3 Jonathan Matthew 2010-01-28 12:12:05 UTC
Committed with appropriate #ifdefs and a bit of testing.

commit a6e3370a200215ddd931d04ab684dcda79dceb7b
Author: Carlos Garnacho <carlos@lanedo.com>
Date:   Thu Jan 28 22:10:14 2010 +1000

    Use new totem_pl_parser_save API where required
Comment 4 Jonathan Matthew 2010-02-26 02:05:21 UTC
*** Bug 611138 has been marked as a duplicate of this bug. ***