GNOME Bugzilla – Bug 605100
GNOME Goal: Remove deprecated glib symbols
Last modified: 2010-06-14 09:27:40 UTC
See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib
tests/examples/app/appsrc-ra.c: g_mapped_file_free (app->file); tests/examples/app/appsrc-seekable.c: g_mapped_file_free (app->file); tests/examples/app/appsrc-stream.c: g_mapped_file_free (app->file); tests/examples/app/appsrc-stream2.c: g_mapped_file_free (app->file); I've just found #define g_mapped_file_unref g_mapped_file_free in gst-libs/gst/tag/lang.c, so I think this bug can be closed, Can some gstreamer devel confirm?
I see no use of g_mapped_file_unref in the code you pasted here. I ain't no GStreamer dev, but this is IMHO a duplicate of bug 560442 which states (see http://bugzilla.gnome.org/show_bug.cgi?id=560442#c11 ): "Use g_mapped_file_unref if Glib >= 2.22 is available" *** This bug has been marked as a duplicate of bug 560442 ***
Hello Luis, that patch was for gstreamer code, this is gst-plugins-base; reopening.
Fixed, thanks for the bug report: commit 6ce1ff2188c9a91cb8d09a2fc3a15cbe8f0fcc95 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Mon Dec 21 07:50:26 2009 +0000 tests: don't use deprecated GLib API g_mapped_file_free Fixes #605100.
Sorry Javier, You're right. I think I should not try to triage bug at 4 in the morning :-p
Commit on 2010-03-30 added usage of g_io_channel_read: $:andre\> grep -r g_io_channel_read . ./tests/examples/seek/jsseek.c: g_io_channel_read (source, buf, sizeof (struct js_event), &bytes_read); Hence reopening. Please consider using "-DG_DISABLE_DEPRECATED" by default.
commit 29fe8adea8e96d5b4522fc83e38525b74fd7a6ce Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Mon Jun 14 11:20:00 2010 +0200 jsseek: Don't use deprecated GLib API Fixes once again bug #605100. commit 7a0fdf5423b537cf7e2d8fffcb5126a8d4b7d438 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Mon Jun 14 11:26:08 2010 +0200 gst-glib.m4: Define G_DISABLE_DEPRECATED for GIT versions If deprecated API is found, for which the replacement is in a newer version of GLib than we currently depend on, use the new API in a #if GLIB_CHECK_VERSION block and remove that block after depending on a new enougb GLib version. Fixes bug #605100.