GNOME Bugzilla – Bug 605090
Fix some compilation warnings
Last modified: 2010-01-04 15:54:35 UTC
Some compilation warning were introduced. Here some patches to fix them
Created attachment 150127 [details] [review] Use G_GSIZE_FORMAT instead of %d
Created attachment 150128 [details] [review] Cast to GTK_WIDGET()
Comment on attachment 150127 [details] [review] Use G_GSIZE_FORMAT instead of %d commit 479c7b047648119f6fb0cf754fdbd3b08acc211e
Comment on attachment 150128 [details] [review] Cast to GTK_WIDGET() commit 134a8ffa194d32843677f89a2424d2b35c1070ca
This problem has been fixed in the development version. The fix will be available in the next major software release.
Sorry Ben, more warnings comming ;)
Created attachment 150148 [details] [review] cast to GTK_WIDGET()
Created attachment 150149 [details] [review] cast to GTK_WIDGET() problem: use new variable
Created attachment 150150 [details] [review] Use G_GSIZE_FORMAT instead of %i
I really think we should use -Werror by default ;)
Created attachment 150190 [details] [review] Use G_GSIZE_FORMAT instead of %d
Comment on attachment 150149 [details] [review] cast to GTK_WIDGET() problem: use new variable Obsolete by commit 3a9633a9de67f0272e120c8e4540f27e4b52712f
Comment on attachment 150148 [details] [review] cast to GTK_WIDGET() Obsolete by commit ac26960e62346558737073ac516790005d7c64ad
Comment on attachment 150190 [details] [review] Use G_GSIZE_FORMAT instead of %d In fact, this error is only triggered for 0 <= icc_profile_size < 127, so casting to int as a recent patch does is fine.
Comment on attachment 150150 [details] [review] Use G_GSIZE_FORMAT instead of %i commit c1cddb2b24014abb50633fe7081b8ad94d111508
Created attachment 150770 [details] [review] Use const gchar instead gchar
Comment on attachment 150770 [details] [review] Use const gchar instead gchar Please make the next_src variable inside the loop const, too.
(In reply to comment #17) > (From update of attachment 150770 [details] [review]) > Please make the next_src variable inside the loop const, too. I'd like to ask what the reason for this: g_utf8_next_char() returns a char*
Good question. git logs don't show anything about it either. Someone should probably file a bug about it.
Comment on attachment 150770 [details] [review] Use const gchar instead gchar commit aa63be61d9082f50523c3c2c796d5a8318673cfe
Closing as the new warnings are now gone, thank you Company for the reviews