GNOME Bugzilla – Bug 604963
Fix application thumbnail sizing when the height is greater than the width of a window.
Last modified: 2010-01-05 01:21:48 UTC
This bug happened because the thumbnail box was only maxed, not set to 256x256. Standard window thumbnails would max out only the width to 256. Having a window with its height greater than its width meant that the height would max out, but not the width, causing thumbnails to look uneven.
Created attachment 150042 [details] [review] Fix application thumbnail sizing when the height is greater than the width of a window. This bug happened because the thumbnail box was only maxed, not set to 256x256. Standard window thumbnails would max out only the width to 256. Having a window with its height greater than its width meant that the height would max out, but not the width, causing thumbnails to look uneven.
Review of attachment 150042 [details] [review]: ::: data/theme/gnome-shell.css @@ +495,2 @@ } +.switcher-list .thumbnail { ".thumbnail" is fairly generic. ".switcher-thumbnail"? @@ -496,2 @@ padding: 6px; .switcher-list .outlined-item-box { I've been trying to namespace the CSS (in an admittedly ad-hoc way), and .switcher-list was there before, but... ::: js/ui/altTab.js @@ +593,3 @@ this._icon = this.app.create_icon_texture(POPUP_APPICON_SIZE); vertical: true }); + this.actor.add(this._icon, { x_fill: false, y_fill: true } ); I don't understand the motivation for y_fill: true. This means we'll be stretching the icon texture if we're allocated a larger height, which is almost always wrong.
Created attachment 150809 [details] [review] Fix application thumbnail sizing when the height is greater than the width of a window. This bug happened because the thumbnail box was only maxed, not set to 256x256. Standard window thumbnails would max out only the width to 256. Having a window with its height greater than its width meant that the height would max out, but not the width, causing thumbnails to look uneven.
Well, I can rename "thumbnail" to "switcher-thumbnail" but you used "thumbnail-box" and "item-box" so I thought I would be consistent. I removed the y_fill though.
Attachment 150042 [details] pushed as 9423cc7 - Fix application thumbnail sizing when the height is greater than the width of a window. Attachment 150809 [details] pushed as 9423cc7 - Fix application thumbnail sizing when the height is greater than the width of a window.