GNOME Bugzilla – Bug 604918
spam from the osd window code
Last modified: 2010-03-10 11:25:00 UTC
Created attachment 150002 [details] [review] patch I've observed this when starting up gnome-power-manager, which ships a copy of the gsd osd window code: (gnome-power-manager:15416): Gdk-CRITICAL **: gdk_window_invalidate_rect_full: assertion `GDK_IS_WINDOW (window)' failed I'll attach a patch that fixes this by only doing work if the window is actually on screen. The patch was done against the g-p-m copy, but will apply just the same to g-s-d.
Adding me as cc, as I'll need to patch g-p-m too.
I actually think the bug is in the gnome-power-manager code, otherwise we'd see this problem in gnome-settings-daemon as well. You can blame me.
it is probably more visible with g-p-m because it creates the osd at startup, apparently, instead of as-needed.
Something like that should fix it: diff --git a/src/gpm-backlight.c b/src/gpm-backlight.c index 23c137e..f24d50d 100644 --- a/src/gpm-backlight.c +++ b/src/gpm-backlight.c @@ -182,6 +182,7 @@ gpm_backlight_dialog_init (GpmBacklight *backlight) if (backlight->priv->popup == NULL) { backlight->priv->popup= gsd_media_keys_window_new (); + gtk_widget_realize (backlight->priv->popup); gsd_media_keys_window_set_action_custom (GSD_MEDIA_KEYS_WINDOW (backlight->priv->popup), "gpm-brightness-lcd", TRUE);
What about this? Still needed? Obsolete?
(In reply to comment #5) > What about this? Still needed? Obsolete? Richard will test the above patch against gnome-power-manager and reassign there if it fixes it.
Created attachment 151748 [details] [review] what's in git master I've committed the following patch to gnome-power-manager which seems to fix the problem. Comments welcomed.
Fine by me.
Reopening, needs doing in g-s-d as well.
Committed to master.