GNOME Bugzilla – Bug 604892
checks fail
Last modified: 2009-12-19 20:09:49 UTC
This is on Mandriva cooker with gtk-doc 1.12: 100 %: Checks 8, Failures: 0 PASS: tools.sh Running suite(s): gtk-doc-tester Cannot open tester-undocumented.txt: No such file or directory FAIL: gobject.sh Running suite(s): gtk-doc-tester Cannot open tester-undocumented.txt: No such file or directory FAIL: bugs.sh Running suite(s): gtk-doc-tester Cannot open tester-undocumented.txt: No such file or directory FAIL: annotations.sh Running suite(s): gtk-doc-fail grep: tester-undocumented.txt: No such file or directory grep: tester-undocumented.txt: No such file or directory grep: tester-undocumented.txt: No such file or directory 100 %: Checks 3, Failures: 0 PASS: fail.sh ======================================================================== 3 of 5 tests failed Please report to http://bugzilla.gnome.org/enter_bug.cgi?product=gtk-doc ========================================================================
those files should be produced by the test runs. Could you have a deeper look?
could you attach the whole make check output?
Created attachment 149997 [details] complete build log
Undefined subroutine &main::CreateValidSGMLID called at /home/goetz/svn/gtk-doc/BUILD/gtk-doc-1.13/gtkdoc-mkdb line 2603, <INPUT> line 2. This function is in gtkdoc-common.pl. You probably have an older version of gtk-doc installed and the way you build the rpm breaks the PERLPATH setting I do in make check to use the uninstalled version. Could you try make check from the tarball? Also i sthat is supposed to beome a official package: gtk-doc was configured with the following options: ================================================== configure: ** Python based tools enabled, using /usr/bin/python configure: ** SGML support enabled, using /usr/bin/openjade configure: XML PDF support disabled, no fop available configure: ** Gnome-doc-utils support enabled configure: ** Scrollkeeper support enabled configure: ** Syntax highlighting of examples enabled, using /bin/vim configure: ** Building regression tests - please install dblatex to have pdf support (I'll fix the messae in the sumary) - please install source-highlight or highlight to get decent syntax highlighting
You are right, uninstalling gtk-doc 1.11 fixes make check. The rpm build doesn't try anything special, just configure, make and make check.
Found it! Its because of this construct in most of the scripts: unshift @INC, '/usr/share/gtk-doc/data'; require "gtkdoc-common.pl"; I'll try to find a way that they can detect that they are running uninstalled. Can you proceed with a 1.13 release. I would include that fix with a 1.14, okay?
Sure, I can use 1.13 for now. And I'll enable dblatex and source-highlight.
Created attachment 150022 [details] [review] append to the perl path so that it stays overrideable Götz, could you try this patch? If it works I'll push it and you can add it localy to the rpm.
Yes, with the patch the checks all succeed.
commit 1f5d323d9ecf6384980c8e51e9d5b30376ce3536 Author: Stefan Kost <ensonic@users.sf.net> Date: Fri Dec 18 21:47:23 2009 +0200 tools: append to the perl path so that it stays overrideable. Fixes #604892 We were prepending datadir to the INC path for perl to find gtkdoc-common.pl. This also caused the unit tests to run with the installed version, despite that we had set an local path to INC from the Makefile.